Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[after beta] revisit overview card formatting #299

Open
zkamvar opened this issue Jun 20, 2022 · 1 comment
Open

[after beta] revisit overview card formatting #299

zkamvar opened this issue Jun 20, 2022 · 1 comment
Labels
accessibility An issue or feature regarding accessibility of the infrastructure or supporting software bug Something isn't working

Comments

@zkamvar
Copy link
Contributor

zkamvar commented Jun 20, 2022

There's been some feedback that the overview card text is too squished. For the most part, I agree and felt that it was coded a bit wonky in the first place. It is worthwhile to revisit this, but likely after we run through the beta phase.

It does need revisiting and I will revisit it when I get the chance. For future reference: because the questions/objectives are special to lessons, they are treated with lua filters in {sandpaper} in combination with CSS styling in {varnish}.

Originally posted by @zkamvar in carpentries/workbench#10 (reply in thread)

@zkamvar
Copy link
Contributor Author

zkamvar commented Nov 30, 2023

Note: the solution for this will likely be to ensure that the questions and objectives columns are both of equal width (right now, they are a 1:2 ratio).

The reason for this design decison was likely an arbitrary one based on the original parameters we gave for the wireframes (i.e. the questions were far shorter than the objectives in the example we provided). The designer implemented it in a way that was not easy to translate to CSS, so the implementers had to fudge it a bit and we got the 1:2 ratio with the wonky squishiness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility An issue or feature regarding accessibility of the infrastructure or supporting software bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant