Address comments

Author: effectfully

plutus-core/plutus-core/src/PlutusCore/Builtin/Result.hs

@@ -164,8 +164,9 @@ We mark error-related definitions such as prisms like '_StructuralUnliftingError
 functions like 'throwNotAConstant' with @INLINE@, because this produces significantly less cluttered
 GHC Core. Not doing so results in 20+% larger Core for builtins.
 
-However in a few specific cases we use @NOINLINE@ instead to get tighter Core. @NOINLINE@ is the same as
-@NOINLINE@ except the former _actually_ prevents GHC from inlining the definition unlike the latter.
+However in a few specific cases we use @NOINLINE@ instead to get tighter Core. @NOINLINE@ is the
+same as @OPAQUE@ except the latter _actually_ prevents GHC from inlining the definition unlike the
+former (we use the former because we currently have to support GHC-8.10).
 See this for details: https://github.com/ghc-proposals/ghc-proposals/blob/5577fd008924de8d89cfa9855fa454512e7dcc75/proposals/0415-opaque-pragma.rst
 
 It's hard to predict where @NOINLINE@ instead of @INLINE@ will help to make GHC Core tidier, so it's

plutus-tx-plugin/test/Plugin/Data/Spec.hs

@@ -1,5 +1,6 @@
 -- editorconfig-checker-disable-file
 {-# LANGUAGE BangPatterns        #-}
+{-# LANGUAGE CPP                 #-}
 {-# LANGUAGE DataKinds           #-}
 {-# LANGUAGE NegativeLiterals    #-}
 {-# LANGUAGE OverloadedStrings   #-}
@@ -16,7 +17,9 @@
 {-# OPTIONS_GHC -fplugin-opt PlutusTx.Plugin:context-level=0 #-}
 {-# OPTIONS_GHC -Wno-incomplete-patterns #-}
 {-# OPTIONS_GHC -Wno-name-shadowing #-}
+#if !MIN_VERSION_base(4, 15, 0)
 {-# OPTIONS_GHC -Wwarn=unrecognised-pragmas #-}
+#endif
 
 module Plugin.Data.Spec where
 

plutus-tx-plugin/test/Plugin/Laziness/Spec.hs

@@ -1,4 +1,5 @@
 -- editorconfig-checker-disable-file
+{-# LANGUAGE CPP                 #-}
 {-# LANGUAGE DataKinds           #-}
 {-# LANGUAGE OverloadedStrings   #-}
 {-# LANGUAGE ScopedTypeVariables #-}
@@ -10,7 +11,9 @@
 {-# OPTIONS_GHC -fplugin-opt PlutusTx.Plugin:max-simplifier-iterations-uplc=0 #-}
 {-# OPTIONS_GHC -fplugin-opt PlutusTx.Plugin:max-cse-iterations=0 #-}
 {-# OPTIONS_GHC -fplugin-opt PlutusTx.Plugin:context-level=0 #-}
+#if !MIN_VERSION_base(4, 15, 0)
 {-# OPTIONS_GHC -Wwarn=unrecognised-pragmas #-}
+#endif
 
 module Plugin.Laziness.Spec where
 

plutus-tx-plugin/test/Plugin/Typeclasses/Spec.hs

@@ -1,3 +1,4 @@
+{-# LANGUAGE CPP                 #-}
 {-# LANGUAGE DataKinds           #-}
 {-# LANGUAGE OverloadedStrings   #-}
 {-# LANGUAGE ScopedTypeVariables #-}
@@ -11,7 +12,9 @@
 {-# OPTIONS_GHC -fplugin-opt PlutusTx.Plugin:max-cse-iterations=0 #-}
 {-# OPTIONS_GHC -fplugin-opt PlutusTx.Plugin:context-level=0 #-}
 {-# OPTIONS_GHC -fplugin-opt PlutusTx.Plugin:no-typecheck #-}
+#if !MIN_VERSION_base(4, 15, 0)
 {-# OPTIONS_GHC -Wwarn=unrecognised-pragmas #-}
+#endif
 
 module Plugin.Typeclasses.Spec where
 

plutus-tx/src/PlutusTx/Bool.hs

@@ -1,4 +1,7 @@
+{-# LANGUAGE CPP #-}
+#if !MIN_VERSION_base(4, 15, 0)
 {-# OPTIONS_GHC -Wwarn=unrecognised-pragmas #-}
+#endif
 
 module PlutusTx.Bool (Bool(..), (&&), (||), not, otherwise) where
 

plutus-tx/src/PlutusTx/Builtins/HasBuiltin.hs

@@ -1,10 +1,13 @@
+{-# LANGUAGE CPP                      #-}
 {-# LANGUAGE FlexibleContexts         #-}
 {-# LANGUAGE FlexibleInstances        #-}
 {-# LANGUAGE StandaloneKindSignatures #-}
 {-# LANGUAGE TypeFamilies             #-}
 {-# LANGUAGE TypeOperators            #-}
 
+#if !MIN_VERSION_base(4, 15, 0)
 {-# OPTIONS_GHC -Wwarn=unrecognised-pragmas #-}
+#endif
 
 module PlutusTx.Builtins.HasBuiltin where
 

plutus-tx/src/PlutusTx/Builtins/HasOpaque.hs

@@ -11,7 +11,9 @@
 {-# OPTIONS_GHC -Wno-orphans #-}
 {-# OPTIONS_GHC -fno-omit-interface-pragmas #-}
 {-# OPTIONS_GHC -fno-specialise #-}
+#if !MIN_VERSION_base(4, 15, 0)
 {-# OPTIONS_GHC -Wwarn=unrecognised-pragmas #-}
+#endif
 
 module PlutusTx.Builtins.HasOpaque where
 

plutus-tx/src/PlutusTx/Function.hs

@@ -1,4 +1,7 @@
+{-# LANGUAGE CPP #-}
+#if !MIN_VERSION_base(4, 15, 0)
 {-# OPTIONS_GHC -Wwarn=unrecognised-pragmas #-}
+#endif
 
 module PlutusTx.Function (fix) where
 

plutus-tx/src/PlutusTx/Optimize/Inline.hs

@@ -1,4 +1,7 @@
+{-# LANGUAGE CPP #-}
+#if !MIN_VERSION_base(4, 15, 0)
 {-# OPTIONS_GHC -Wwarn=unrecognised-pragmas #-}
+#endif
 
 module PlutusTx.Optimize.Inline (inline) where
 

plutus-tx/src/PlutusTx/Plugin/Utils.hs

@@ -1,3 +1,4 @@
+{-# LANGUAGE CPP                #-}
 {-# LANGUAGE DataKinds          #-}
 {-# LANGUAGE DerivingStrategies #-}
 {-# LANGUAGE FlexibleContexts   #-}
@@ -6,7 +7,9 @@
 
 {-# OPTIONS_GHC -Wno-unused-foralls #-}
 {-# OPTIONS_GHC -fomit-interface-pragmas #-}
+#if !MIN_VERSION_base(4, 15, 0)
 {-# OPTIONS_GHC -Wwarn=unrecognised-pragmas #-}
+#endif
 
 module PlutusTx.Plugin.Utils where