-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(global): replace yellow-20 with yellow-30 #4287
Conversation
@laurenmrice let me know if we should remove references to yellow-20 from the documentation as well |
Deploy preview for the-carbon-components ready! Built with commit 1104c69 https://deploy-preview-4287--the-carbon-components.netlify.com |
Deploy preview for carbon-elements failed. Built with commit 1104c69 https://app.netlify.com/sites/carbon-elements/deploys/5d9f81d68d03b50007ecc264 |
Deploy preview for carbon-components-react failed. Built with commit 1104c69 https://app.netlify.com/sites/carbon-components-react/deploys/5d9f81d6b34d48000aa3eda1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 - Thanks @AlexanderLyon!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me pending visual review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great thank you ! 🙌
Closes #4141
Since yellow-20 is being deprecated, this replaces
$ibm-color__yellow-20
with$ibm-color__yellow-30
(#f1c21b). The alters the background color used in warning notifications.Changelog
Changed
_theme-tokens.scss