Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(global): replace yellow-20 with yellow-30 #4287

Merged
merged 3 commits into from
Oct 10, 2019

Conversation

AlexanderLyon
Copy link
Contributor

Closes #4141

Since yellow-20 is being deprecated, this replaces $ibm-color__yellow-20 with $ibm-color__yellow-30 (#f1c21b). The alters the background color used in warning notifications.

Changelog

Changed

  • _theme-tokens.scss

image

@AlexanderLyon AlexanderLyon requested a review from a team as a code owner October 10, 2019 01:25
@ghost ghost requested review from emyarod and jnm2377 October 10, 2019 01:26
@AlexanderLyon
Copy link
Contributor Author

@laurenmrice let me know if we should remove references to yellow-20 from the documentation as well

@netlify
Copy link

netlify bot commented Oct 10, 2019

Deploy preview for the-carbon-components ready!

Built with commit 1104c69

https://deploy-preview-4287--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Oct 10, 2019

Deploy preview for carbon-elements failed.

Built with commit 1104c69

https://app.netlify.com/sites/carbon-elements/deploys/5d9f81d68d03b50007ecc264

@netlify
Copy link

netlify bot commented Oct 10, 2019

Deploy preview for carbon-components-react failed.

Built with commit 1104c69

https://app.netlify.com/sites/carbon-components-react/deploys/5d9f81d6b34d48000aa3eda1

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @AlexanderLyon!

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me pending visual review

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thank you ! 🙌

@jnm2377 jnm2377 merged commit 32c76bb into carbon-design-system:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[colors] Deprecate yellow-20 and keep yellow-30 with v2 color palette update
6 participants