fix(search): remove role attr and label from skeleton #4272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-components-react failed. Built with commit dd01ff9 https://app.netlify.com/sites/carbon-components-react/deploys/5d9fa54cc219e20008c99e2c |
|
Hey also, side note -- I noticed that this component is a class but maybe it doesn't need to be? I could do a quick little refactor to turn it into a simple functional component 🤔 Want me to do that in this PR? |
|
Deploy preview for carbon-elements ready! Built with commit dd01ff9 |
|
Deploy preview for the-carbon-components ready! Built with commit dd01ff9 https://deploy-preview-4272--the-carbon-components.netlify.com |
joshblack
approved these changes
Oct 9, 2019
emyarod
approved these changes
Oct 10, 2019
|
it looks good to go as-is but feel free to do the refactor in a separate PR if this gets merged in before you're able to push it and get re-reviews |
vpicone
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4179
Proposal to remove the
role="search"attribute from this component and replace thelabelelement with a simplespan. My reasoning here is that there doesn't appear to be a real need for the role attribute and alabelelement since this is a non-interactivediv. This would also remove the DAP violations.Changelog
Changed
labelelement to aspanRemoved
role="search"attributehtmlForattribute