From 6be11ccc12b4c6a44313c41e13cb010b920ae0cd Mon Sep 17 00:00:00 2001 From: Harish Mohanani Date: Mon, 4 May 2020 20:14:55 +0530 Subject: [PATCH] fix(dropdown): fix inline field height not adapting to prop size change (#5988) * fix(dropdown): removed default height of inline list box and drop-down * fix(dropdown): updated the docs Co-authored-by: TJ Egan Co-authored-by: Akira Sudoh --- packages/components/docs/sass.md | 7 ------- packages/components/src/components/dropdown/_dropdown.scss | 1 - packages/components/src/components/list-box/_list-box.scss | 6 ------ 3 files changed, 14 deletions(-) diff --git a/packages/components/docs/sass.md b/packages/components/docs/sass.md index 051bf1c4a88f..1beaf0992489 100644 --- a/packages/components/docs/sass.md +++ b/packages/components/docs/sass.md @@ -17608,7 +17608,6 @@ Dropdown styles display: inline-block; border-bottom-color: transparent; width: auto; - height: rem(32px); background-color: transparent; transition: background $duration--fast-01 motion(entrance, productive); @@ -18734,12 +18733,6 @@ List box styles background-color: $field-02; } - .#{$prefix}--list-box.#{$prefix}--list-box--inline, - .#{$prefix}--list-box.#{$prefix}--list-box--inline - .#{$prefix}--list-box__field { - height: rem(32px); - } - .#{$prefix}--list-box.#{$prefix}--list-box--inline .#{$prefix}--list-box__field { padding: 0 carbon--mini-units(4) 0 $carbon--spacing-03; diff --git a/packages/components/src/components/dropdown/_dropdown.scss b/packages/components/src/components/dropdown/_dropdown.scss index 87e72c45ce72..db38b3b74830 100644 --- a/packages/components/src/components/dropdown/_dropdown.scss +++ b/packages/components/src/components/dropdown/_dropdown.scss @@ -350,7 +350,6 @@ display: inline-block; border-bottom-color: transparent; width: auto; - height: rem(32px); background-color: transparent; transition: background $duration--fast-01 motion(entrance, productive); diff --git a/packages/components/src/components/list-box/_list-box.scss b/packages/components/src/components/list-box/_list-box.scss index 66612a7db737..23eb1a6d2afe 100644 --- a/packages/components/src/components/list-box/_list-box.scss +++ b/packages/components/src/components/list-box/_list-box.scss @@ -229,12 +229,6 @@ $list-box-menu-width: rem(300px); background-color: $field-02; } - .#{$prefix}--list-box.#{$prefix}--list-box--inline, - .#{$prefix}--list-box.#{$prefix}--list-box--inline - .#{$prefix}--list-box__field { - height: rem(32px); - } - .#{$prefix}--list-box.#{$prefix}--list-box--inline .#{$prefix}--list-box__field { padding: 0 carbon--mini-units(4) 0 $carbon--spacing-03;