Skip to content

Commit ddd1b85

Browse files
author
Muhammad Naufal Andika Natsir Putra
committed
chore: remove unittest related to image tag
1 parent 65f9d3e commit ddd1b85

File tree

1 file changed

+0
-39
lines changed

1 file changed

+0
-39
lines changed

api/turing/imagebuilder/imagebuilder_test.go

Lines changed: 0 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -643,45 +643,6 @@ func TestBuildPyFuncEnsemblerServiceImage(t *testing.T) {
643643
artifactServiceMock.On("ReadArtifact", mock.Anything, modelDependenciesURL).Return([]byte(testCondaEnvContent), nil)
644644
},
645645
},
646-
"failure: image tag not matched": {
647-
expectedImageBuildingError: "error building OCI image",
648-
projectName: projectName,
649-
modelName: modelName,
650-
modelID: modelVersion,
651-
versionID: runID,
652-
clusterController: func() cluster.Controller {
653-
ctlr := &clustermock.Controller{}
654-
// First time it's called
655-
ctlr.On(
656-
"GetJob",
657-
mock.Anything,
658-
mock.Anything,
659-
mock.Anything,
660-
).Return(
661-
nil,
662-
k8serrors.NewNotFound(
663-
schema.GroupResource{},
664-
fmt.Sprintf("service-builder-%s-%s-%d-%s", projectName, modelName, modelVersion, runID[:5]),
665-
),
666-
).Once()
667-
return ctlr
668-
},
669-
buildLabels: map[string]string{
670-
"gojek.io/team": "dsp",
671-
},
672-
imageBuildingConfig: imageBuildingConfig,
673-
ensemblerFolder: ensemblerFolder,
674-
imageTag: "3.8.*",
675-
artifactServiceMock: func(artifactServiceMock *mocks.Service) {
676-
modelDependenciesURL := getHashedModelDependenciesUrl()
677-
artifactServiceMock.On("ParseURL", fmt.Sprintf("gs%s", testArtifactURISuffix)).Return(testArtifactGsutilURL, nil)
678-
artifactServiceMock.On("GetURLScheme").Return("gs")
679-
artifactServiceMock.On("GetURLScheme").Return("gs")
680-
artifactServiceMock.On("ReadArtifact", mock.Anything, fmt.Sprintf("gs%s", testCondaEnvUrlSuffix)).
681-
Return([]byte(testCondaEnvContent), nil)
682-
artifactServiceMock.On("ReadArtifact", mock.Anything, modelDependenciesURL).Return([]byte(testCondaEnvContent), nil)
683-
},
684-
},
685646
}
686647

687648
for name, tt := range tests {

0 commit comments

Comments
 (0)