working on initialize and linking groupdefs #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jberg
changed the title
|
|
||
| function uuid () { | ||
| return '_' + Math.random().toString(36).substr(2, 9); | ||
| } |
There was a problem hiding this comment.
This could probably just be:
let id = 0;
function getId() {
return id++;
}
There was a problem hiding this comment.
haha, had intended on coming back to that with something less hacky ..... but yea, really no reason I can just increment! haha
| retArr.push(arr[i]); | ||
| } | ||
| return arr.map((v) => parseFloat(v)); | ||
| } |
There was a problem hiding this comment.
retArr is never used?
function splitValues(str) {
return str.split(",").map(parseFloat);
}
There was a problem hiding this comment.
lol, nice catch. yay extra for loop hah!
experiments/modern/src/initialize.js
Outdated
| }) | ||
| ); | ||
| } | ||
| // remove comments other trimmed nodes | ||
| resolvedChildren = resolvedChildren.filter(item => item !== undefined); |
There was a problem hiding this comment.
I personally prefer to use a new variable name in cases like this.
There was a problem hiding this comment.
yea, me too. I was starting to feel like the naming was getting silly like now I add filteredResolvedChildren or something, but probably better than mutating things :D
jberg
changed the title
captbaritone
pushed a commit
that referenced
this pull request
Nov 30, 2019
* move images to initialize * return nodes from initialize, lookup groupdefs * fix attributes when copying groupdefs * position groups with x/y * more parsers for classic modern skin * if img doesn't exist just return the node without adding to registry * dont need nested node * simplify ids * simplify splitValues * new variable with name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.