Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native media player event changed end reached -> stopping #1123

Closed
caprica opened this issue Mar 12, 2022 · 4 comments
Closed

Native media player event changed end reached -> stopping #1123

caprica opened this issue Mar 12, 2022 · 4 comments
Labels
Task
Milestone
vlcj 5.0.0 Release

Comments

@caprica
Copy link
Owner

caprica commented Mar 12, 2022

See https://code.videolan.org/videolan/vlc/-/commit/c338de7b64bd18f820b067dcc944913b5e50d4a3.
@caprica caprica added the Task label Mar 12, 2022
@caprica caprica added this to the vlcj 5.0.0 Release milestone Mar 12, 2022
@caprica
Copy link
Owner Author

caprica commented Mar 14, 2022

Partially done at caprica/vlcj-natives@07e7bb5 in vlcj-natives.

@caprica
Copy link
Owner Author

caprica commented Mar 14, 2022 •
edited
Loading

Thel vlcj media player listeners and the associated event will need to change as well.

The listener associated with this event currently is "finished", which is a bit problematic - the media is not finished until the async stopped event is reached.

Need to check if this changes any vlcj assumed semantics around stopping/ending.

@caprica
Copy link
Owner Author

caprica commented Mar 14, 2022

The special-case OneShotMediaPlayerEventListener is also impacted by this.

@caprica
Copy link
Owner Author

caprica commented Mar 14, 2022 •
edited
Loading

Complete at e0c2ada.

A note for vlcj users that this method was renamed at 1f6659b.

@caprica caprica closed this as completed Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task
Projects
None yet
Milestone
vlcj 5.0.0 Release
Development

No branches or pull requests
1 participant
@caprica