Don't register schema by default. #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't really need this, and it pulls in fmt.
We know the type at generation time, so there's no need for this.
This patch changes code generation so that it doesn't register schema with the schemas package's DefaultRegistry by default. Instead, we expose a RegisterSchemas function which must be invoked on the relevant registry. This is a step towards capnproto#89. The default registry still exists, and APIs like pogs still use it implicitly, so there is more work to do. This should make it a bit easier for the compiler to do dead-code elimination for the schema blobs. This shaves about 28K off the tempest WASM blob. (432K down from 460K).
lthibault
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is stacked on top of #478; review & merge that first.
This patch changes code generation so that it doesn't register schema
with the schemas package's DefaultRegistry by default. Instead, we
expose a RegisterSchemas function which must be invoked on the relevant
registry.
This is a step towards #89. The default registry still exists, and APIs
like pogs still use it implicitly, so there is more work to do.
This should make it a bit easier for the compiler to do dead-code
elimination for the schema blobs. This shaves about 28K off the tempest
WASM blob. (432K down from 460K).