Use migration command to construct log message #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks for catching this! No need to modify the CHANGELOG, the release notes are now generated automatically from the PR titles. I'll make sure the PR checklist is updated to remove the CHANGELOG from the checklist. |
|
Sounds great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up to #242 , which introduced the
migration_commandconfiguration option. It's a great option that we're keen to use (as we use data migrations in our project). When upgrading, I noticed that the informational log message still says "Runningrake db:migrate", even if a different migration command is provided.This PR updates the log message to also dynamically print a message based on the provided migration command.
Short checklist
Other Information
☝️ I'm not sure where to make the CHANGELOG entry. If you could point me in the right direction, I can add a note about this change to the appropriate CHANGELOG, thanks!