Merge pull request #22 from crux153/master

capaj · web-flow · commit 4cb36124cb1f · 2018-06-12T23:39:54.000+02:00
Update on className change
diff --git a/tweet-embed.js b/tweet-embed.js
@@ -47,11 +47,16 @@ class TweetEmbed extends React.Component {
   }
 
   shouldComponentUpdate (nextProps, nextState) {
-    return this.props.id !== nextProps.id
+    return (
+      this.props.id !== nextProps.id ||
+      this.props.className !== nextProps.className
+    )
   }
 
   componentWillUpdate (nextProps, nextState) {
-    this.loadTweetForProps(nextProps)
+    if (this.props.id !== nextProps.id) {
+      this.loadTweetForProps(nextProps)
+    }
   }
 
   render () {

Original file line number	Diff line number	Diff line change
`@@ -47,11 +47,16 @@ class TweetEmbed extends React.Component {`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`shouldComponentUpdate (nextProps, nextState) {`
`50`		`- return this.props.id !== nextProps.id`
	`50`	`+ return (`
	`51`	`+ this.props.id !== nextProps.id \|\|`
	`52`	`+ this.props.className !== nextProps.className`
	`53`	`+ )`
`51`	`54`	`}`
`52`	`55`
`53`	`56`	`componentWillUpdate (nextProps, nextState) {`
`54`		`- this.loadTweetForProps(nextProps)`
	`57`	`+ if (this.props.id !== nextProps.id) {`
	`58`	`+ this.loadTweetForProps(nextProps)`
	`59`	`+ }`
`55`	`60`	`}`
`56`	`61`
`57`	`62`	`render () {`