Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Capacitor 3 Support #149

Closed
FabianMeul opened this issue May 26, 2021 · 4 comments · Fixed by #157
Closed

Feat: Capacitor 3 Support #149

FabianMeul opened this issue May 26, 2021 · 4 comments · Fixed by #157
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@FabianMeul
Copy link

FabianMeul commented May 26, 2021

Capacitor version:

Run npx cap doctor:

💊   Capacitor Doctor  💊

Latest Dependencies:

  @capacitor/cli: 3.0.0
  @capacitor/core: 3.0.0
  @capacitor/android: 3.0.0
  @capacitor/ios: 3.0.0

Installed Dependencies:

  @capacitor/cli: 3.0.0
  @capacitor/ios: 3.0.0
  @capacitor/android: 3.0.0
  @capacitor/core: 3.0.0

[success] iOS looking great! 👌
[success] Android looking great! 👌

Library version:

  • 2.1.0

Affected Platform(s):

  • iOS

Current Behavior

xCode refused to build because the plugin has its build target set to 11.0. Capacitor 3 requires it to be set to 12.0.

Expected Behavior

Builds succeed when using Capacitor 3.

Other Information

Any information on when this plugin might get updated to support Capacitor 3.0? :-)

EDIT: Seems to be related to this one as well (Android): #136

@moberwasserlechner moberwasserlechner changed the title Bug: Capacitor 3 Support Feat: Capacitor 3 Support May 26, 2021
@moberwasserlechner
Copy link
Collaborator

I changed it to feat ;)

I can't give a ETA but I have planed OSS work for first week in June.

@moberwasserlechner moberwasserlechner added the enhancement New feature or request label May 26, 2021
@FabianMeul
Copy link
Author

Thx for the quick response!

I managed to get it working by following the xCode "fix" suggestions.

let success: Bool! = handlerInstance.logout(viewController: (bridge?.viewController!)!, call: call)

The code issue is situated at bridge.viewController.

@moberwasserlechner
Copy link
Collaborator

Hey,

Thanks for the snippet.

I would be careful as the plugin does not support Cap 3 at all. Currently I have no idea if the typescript part is ready to be used with Cap 3 or not.

BR

@moberwasserlechner moberwasserlechner added this to the 3.0.0 milestone May 26, 2021
@pdsullivan
Copy link

pdsullivan commented May 26, 2021

running into this as well. updating the swift code like was suggested above did get it working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants