Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New requirements for gradle 8 #37

Closed
luca-peruzzo opened this issue May 5, 2023 · 1 comment
Closed

New requirements for gradle 8 #37

luca-peruzzo opened this issue May 5, 2023 · 1 comment
Assignees
Labels
chore enhancement New feature or request
Milestone

Comments

@luca-peruzzo
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch @capacitor-community/file-opener@1.0.4 for the project I'm working on.

Please replace the package attribute in AndroidManifest.xml with the namespace attribute in build.gradle cause is required by gradle 8.

Here is the diff that solved my problem:

diff --git a/node_modules/@capacitor-community/file-opener/android/build.gradle b/node_modules/@capacitor-community/file-opener/android/build.gradle
index 3de9898..6b91629 100644
--- a/node_modules/@capacitor-community/file-opener/android/build.gradle
+++ b/node_modules/@capacitor-community/file-opener/android/build.gradle
@@ -18,6 +18,7 @@ buildscript {
 apply plugin: 'com.android.library'
 
 android {
+    namespace "com.ryltsov.alex.plugins.file.opener"
     compileSdkVersion project.hasProperty('compileSdkVersion') ? rootProject.ext.compileSdkVersion : 32
     defaultConfig {
         minSdkVersion project.hasProperty('minSdkVersion') ? rootProject.ext.minSdkVersion : 22
diff --git a/node_modules/@capacitor-community/file-opener/android/src/main/AndroidManifest.xml b/node_modules/@capacitor-community/file-opener/android/src/main/AndroidManifest.xml
index a06bff2..3ff16af 100644
--- a/node_modules/@capacitor-community/file-opener/android/src/main/AndroidManifest.xml
+++ b/node_modules/@capacitor-community/file-opener/android/src/main/AndroidManifest.xml
@@ -1,5 +1,4 @@
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    package="com.ryltsov.alex.plugins.file.opener">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android">
 
     <application>
         <provider

This issue body was partially generated by patch-package.

@ryaa ryaa self-assigned this May 7, 2023
@ryaa ryaa added enhancement New feature or request chore labels May 7, 2023
@ryaa ryaa added this to the v1.0.5 milestone May 7, 2023
@ryaa
Copy link
Member

ryaa commented May 7, 2023

The required changes have been included into the new release 1.0.5 - see https://github.com/capacitor-community/file-opener/blob/chore/release-1.0.5/CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants