This repository has been archived by the owner on Oct 10, 2024. It is now read-only.
fix(ios): added self. to savedCall in scan() #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 9, 2022
Closed
|
Thank you @hauserkristof |
thegnuu
added a commit
that referenced
this pull request
Aug 10, 2022
* feat(capacitor): update to capacitor v4 * fix(ios): small bugfixes * fix(ios): added self. to savedCall in scan() (#142) Co-authored-by: Kristof Hauser <hauser.kristof@gmail.com>
thegnuu
added a commit
that referenced
this pull request
Nov 18, 2022
* ⬆️ Bump minimist from 1.2.5 to 1.2.6 (#112) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Reset last scanned code when resuming scan (#116) * Update BarcodeScanner.java reset scanResult after calling resumeScan * Update Plugin.swift reset scan result after calling resumeScan * 2.1.1 * fix IOS orientation (#131) Steps to reproduce : open the app in portrait/landscape mode => rotate => open the camera Issue the CameraView was being loaded when the app starts not with each scan. Somehow the cameraView doesn't recognize that the app has rotated * Capacitor v4 (#143) * feat(capacitor): update to capacitor v4 * fix(ios): small bugfixes * fix(ios): added self. to savedCall in scan() (#142) Co-authored-by: Kristof Hauser <hauser.kristof@gmail.com> * 3.0.0 * Add more detailed troubleshooting to the README (#152) Added more detailed troubleshooting, with a fix for the following #151 * fix(readme): typos and other enhancements * iOS interface orientation obsolete (#146) On iOS the `UIApplication.shared.statusBarOrientation` is deprecated and on newer versions obsolete. It has been replaced by code suggested here: https://askcodes.net/coding/-statusbarorientation--was-deprecated-in-ios-13-0-when-attempting-to-get-app-orientation #129 * fix(readme): added ionic stuff * updating definitions * adding dependencies * updating permisions * feat: Adding ML-Kit Logic * updating XML Layout * adding base for graphic drawing Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: PaintedShepherd <painted.shepherd@gmail.com> Co-authored-by: Yannik Ache Eicher <ache@bbit.io> Co-authored-by: Mohamed Abdelgwad <4671486+scr2em@users.noreply.github.com> Co-authored-by: Kristof Hauser <hauser.kristof@gmail.com> Co-authored-by: Raphaël Balet <raphael.balet@outlook.com> Co-authored-by: Robin <rattenval@hotmail.com> Co-authored-by: Abdulaziz Alghamdi <a.alghamdi@juleb.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After tyring to build it Xcode failed because of missing reference:
Fixed it, and it is working properly on iOS, with Ionic Angular:
❯ npx cap doctor
💊 Capacitor Doctor 💊
Latest Dependencies:
@capacitor/cli: 4.0.1
@capacitor/core: 4.0.1
@capacitor/android: 4.0.1
@capacitor/ios: 4.0.1
Installed Dependencies:
@capacitor/cli: 4.0.1
@capacitor/core: 4.0.1
@capacitor/android: 4.0.1
@capacitor/ios: 4.0.1
[success] iOS looking great! 👌