Skip to content
This repository has been archived by the owner on Oct 10, 2024. It is now read-only.

Reset last scanned code when resuming scan #116

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

PaintedShepherd
Copy link
Contributor

This is a fork where the last scanned code is resetted when resumeScan() is called.
So you can scan the same code again when you resume scanning.
It's working on iOS and Android in my case.

Feel free to test, especially when using the startScan()-function.

reset scanResult after calling resumeScan
reset scan result after calling resumeScan
@thegnuu
Copy link
Collaborator

thegnuu commented Apr 13, 2022

Thanks a lot @PaintedShepherd ! I will test it and create a release as fast as possible!

This closes #114 since it contains the fix for iOS as well, thanks @PierreB40 for your work anyways!

@thegnuu
Copy link
Collaborator

thegnuu commented Apr 14, 2022

Unfortunately Apple is preventing me from doing any kind of development of Apps at the moment. My Xcode is stuck with preparing my Apple Watch and all of the available hints to resolve this issue are not working... I don't know what to do at the moment.

Anyway - since it is just a minimal change and I cannot see any issues that could be caused by this change I will just release it without additional tests....

Thanks for helping out @PaintedShepherd !

@thegnuu thegnuu merged commit 7bdd880 into capacitor-community:main Apr 14, 2022
@binarybase
Copy link

Unfortunately Apple is preventing me from doing any kind of development of Apps at the moment. My Xcode is stuck with preparing my Apple Watch and all of the available hints to resolve this issue are not working... I don't know what to do at the moment.

Anyway - since it is just a minimal change and I cannot see any issues that could be caused by this change I will just release it without additional tests....

Thanks for helping out @PaintedShepherd !

Regarding the Xcode Apple Watch issue. I had the same trouble... Try to unpair your phone, then power off watch, power off the iphone, pair iphone, wait for sync and then start watch. It's very annoying.

@thegnuu
Copy link
Collaborator

thegnuu commented Apr 18, 2022

Yeah I already did a lot of stuff, even turning off the watch completely and restarting all devices aso. was not doing anything most of the time. I was lucky if I could start a project once a day. Really annoying, but today Xcode decided to install an update for the command line tools and now everything seems to work again without any issues...

Thanks for your suggestions anyway!

thegnuu added a commit that referenced this pull request Nov 18, 2022
* ⬆️ Bump minimist from 1.2.5 to 1.2.6 (#112)

Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Reset last scanned code when resuming scan (#116)

* Update BarcodeScanner.java

reset scanResult after calling resumeScan

* Update Plugin.swift

reset scan result after calling resumeScan

* 2.1.1

* fix IOS orientation (#131)

Steps to reproduce :
open the app in portrait/landscape mode => rotate => open the camera 

Issue
the CameraView was being loaded when the app starts not with each scan.

Somehow the cameraView doesn't recognize that the app has rotated

* Capacitor v4 (#143)

* feat(capacitor): update to capacitor v4

* fix(ios): small bugfixes

* fix(ios): added self. to savedCall in scan() (#142)

Co-authored-by: Kristof Hauser <hauser.kristof@gmail.com>

* 3.0.0

* Add more detailed troubleshooting to the README (#152)

Added more detailed troubleshooting, with a fix for the following  #151

* fix(readme): typos and other enhancements

* iOS interface orientation obsolete (#146)

On iOS the `UIApplication.shared.statusBarOrientation` is deprecated and on newer versions obsolete. It has been replaced by code suggested here:
https://askcodes.net/coding/-statusbarorientation--was-deprecated-in-ios-13-0-when-attempting-to-get-app-orientation
#129

* fix(readme): added ionic stuff

* updating definitions

* adding dependencies

* updating permisions

* feat: Adding ML-Kit Logic

* updating XML Layout

* adding base for graphic drawing

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: PaintedShepherd <painted.shepherd@gmail.com>
Co-authored-by: Yannik Ache Eicher <ache@bbit.io>
Co-authored-by: Mohamed Abdelgwad <4671486+scr2em@users.noreply.github.com>
Co-authored-by: Kristof Hauser <hauser.kristof@gmail.com>
Co-authored-by: Raphaël Balet <raphael.balet@outlook.com>
Co-authored-by: Robin <rattenval@hotmail.com>
Co-authored-by: Abdulaziz Alghamdi <a.alghamdi@juleb.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants