Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement eachOf via keyIterator #853

Merged
merged 1 commit into from
Jul 20, 2015
Merged

Implement eachOf via keyIterator #853

merged 1 commit into from
Jul 20, 2015

Conversation

megawac
Copy link
Collaborator

@megawac megawac commented Jul 20, 2015

The main advantage of this is if we plan further refactors (#839, #847)

Can't believe this worked in one try (:D)

@aearly
Copy link
Collaborator

aearly commented Jul 20, 2015

Cool. I thought this method already used the key iterator...

@megawac
Copy link
Collaborator Author

megawac commented Jul 20, 2015

Only one more place uses _objectEach now too

aearly added a commit that referenced this pull request Jul 20, 2015
Implement eachOf via keyIterator
@aearly aearly merged commit db7a645 into caolan:master Jul 20, 2015
@charlierudolph
Copy link
Contributor

This was editing dist exclusively. I think this needs to be reverted and applied to lib

@megawac
Copy link
Collaborator Author

megawac commented Jul 22, 2015

Ha, whoops, want to do that @charlierudolph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants