Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defend against multiple callbacks in async.waterfall #815

Closed
aearly opened this issue Jun 30, 2015 · 1 comment · Fixed by #1050
Closed

Defend against multiple callbacks in async.waterfall #815

aearly opened this issue Jun 30, 2015 · 1 comment · Fixed by #1050
Labels
breaking-change
Milestone
2.0

Comments

@aearly
Copy link
Collaborator

aearly commented Jun 30, 2015

This would invalidate the test here: https://github.com/caolan/async/blob/master/test/test-async.js#L883

It will enable use to simplify the implementation significantly, and improve performance.
@aearly aearly added this to the 2.0 milestone Jun 30, 2015
@aearly aearly mentioned this issue Jun 30, 2015
Closed
@charlierudolph
Copy link
Contributor

👍

@franciscop franciscop mentioned this issue Dec 23, 2015
Closed
@aearly aearly mentioned this issue Mar 7, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Waterfall multiple callback defense caolan/async
2 participants
@aearly @charlierudolph