Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GrokImageCompression urls fail #669

Open
jcoyne opened this issue Jul 3, 2024 · 3 comments
Open

GrokImageCompression urls fail #669

jcoyne opened this issue Jul 3, 2024 · 3 comments

Comments

@jcoyne
Copy link
Contributor

jcoyne commented Jul 3, 2024

It's in all the Dockerfiles. Here is an exemplar:

RUN wget -q https://github.com/GrokImageCompression/grok/releases/download/v7.6.5/libgrokj2k1_7.6.5-1_amd64.deb \
&& wget -q https://github.com/GrokImageCompression/grok/releases/download/v7.6.5/grokj2k-tools_7.6.5-1_amd64.deb \

➜  curl https://github.com/GrokImageCompression/grok/releases/download/v7.6.5/libgrokj2k1_7.6.5-1_amd64.deb
Not Found%
➜  curl https://github.com/GrokImageCompression/grok/releases/download/v7.6.5/grokj2k-tools_7.6.5-1_amd64.deb
Not Found%

In the release branch we've commented this code out:
https://github.com/cantaloupe-project/cantaloupe/blob/release/5.0/docker/Linux-GraalVM20/Dockerfile#L35-L39

@ksclarke
Copy link
Contributor

ksclarke commented Jul 3, 2024

Three months ago, the Grok project (https://github.com/GrokImageCompression/grok/) wiped its repository history and removed all old releases. They then released a new library version, and the repository was reset to a completely clean state. We asked about this change on the discussion board, and the question was closed. We asked about it, then, in a ticket/issue, and were told the project would not maintain its previous history or continue to host the old releases. Checking back on the project's repo now, I see all the old issues (including ours asking about the change) have also now been deleted and that the discussion board is no longer available.

UCLA made the decision that we were not comfortable relying on an upstream project with these practices and removed Grok from our Cantaloupe Docker image. The question for the larger Cantaloupe community would be whether we want to update its Dockerfile builds and documentation to reference the new version of Grok or remove it from Cantaloupe's list of supported libraries. UCLA's Docker image was reconfigured to use OpenJPEG (and Kakadu if the binaries are available). Still, I think this is a question for the Cantaloupe community to decide which path the Cantaloupe project should take. Are there people/institutions relying on Grok for its speed advantage over OpenJPEG (but not using Kakadu because of its proprietary license)?

Which path should Cantaloupe take?

@mmatela
Copy link

mmatela commented Aug 1, 2024

Are there people/institutions relying on Grok for its speed advantage over OpenJPEG (but not using Kakadu because of its proprietary license)?

I am one of those, so I would very much prefer for the Grok support to continue.
Do you really need to drop the support for Grok altogether? It's perfectly understandable if you don't include it in your docker files, but why not let us install it at our own risk?

@jcoyne
Copy link
Contributor Author

jcoyne commented Aug 1, 2024

@mmatela Thank you for speaking up in support of this feature. The biggest problem right now is that we don't have any contributors who use Grok. This makes it challenging for any of us to try and support it, as we are just not familiar with it. Would you be willing to volunteer to become a maintainer? Can you upgrade Grok to version 13 in Cantaloupe and ensure it's working correctly still?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants