Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest Vanilla turns white links in global nav black #5031

Closed
steverydz opened this issue Mar 18, 2024 · 1 comment · Fixed by canonical/global-nav#282
Closed

Latest Vanilla turns white links in global nav black #5031

steverydz opened this issue Mar 18, 2024 · 1 comment · Fixed by canonical/global-nav#282
Labels
Bug 🐛

Comments

@steverydz
Copy link
Contributor

When using the latest version of Vanilla (4.9.0) the heading links in the global nav are the same as the default text colour.

The version of global nav in use here is 3.6.2

Screenshot 2024-03-18 at 14 16 26
@bartaz
Copy link
Member

bartaz commented Mar 18, 2024

Yes, that's a bit of an unexpected breaking change introduced in Vanilla 4.8.0 with new theming of links (incuding inverted link).

Addressed in global-nav here: canonical/global-nav#282

@bartaz bartaz mentioned this issue Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update demo to Vanilla 4.9.0 and fix inverted links theming canonical/global-nav
2 participants
@bartaz @steverydz