feat: Add terraform module #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DnPlas
reviewed
Sep 19, 2024
DnPlas
reviewed
Sep 19, 2024
There was a problem hiding this comment.
Thanks @orfeas-k, left a comment. Similar to your PR for notebook operators, I think it would be beneficial if we set the default channel to latest/edge in the re-usable wf. Let me know your decision and if you change this PR to reflect that change, as that was the only thing I noticed.
This was referenced Sep 24, 2024
Closed
Closed
|
@DnPlas thank you for your contribution to this effort, updated! |
This was referenced Sep 24, 2024
orfeas-k
added a commit
that referenced
this pull request
Sep 24, 2024
Create a `terraform/` directory that hosts the Terraform module for this charm. It follows the structure proposed in [this spec](https://docs.google.com/document/d/1EG71A2pJ244PQRaGVzGj7Mx2B_bzE4U_OSqx4eeVI1E/edit) and it is follows what was done in canonical/argo-operators#198. Ref #197
orfeas-k
added a commit
that referenced
this pull request
Sep 26, 2024
feat: Backport terraform module from #200
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a
terraform/directory that hosts the Terraform module for this charm. It follows the structure proposed in this spec and it is follows what was done in canonical/argo-operators#198.To test the module:
tox -e tflintto ensure that linting is correctterraform apply -var "channel=latest/edge" -var "model_name=kubeflow" --auto-approveand wait until the charm isActiveandIdle.Ref #197