Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o/snapstate: download, link, unlink, and discard snap icon in snapstate handlers #15070

Merged
merged 9 commits into from
Feb 20, 2025
Merged

o/snapstate: download, link, unlink, and discard snap icon in snapstate handlers #15070

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c59ee48
dirs: add directories for downloaded snap icons and installed snap icons
olivercalder Jan 30, 2025
b8b77cf
o/snapstate/backend: add functions to link, unlink, and discard snap …
olivercalder Feb 12, 2025
26a82a4
o/snapstate,store: make DownloadIcon a method on the store instance
olivercalder Feb 12, 2025
86e640d
o/snapstate{,/backend}: manage icons via metadata helpers
olivercalder Feb 13, 2025
1e3747b
o/snapstate: download snap icon after downloading snap file
olivercalder Feb 13, 2025
1e4c430
o/snapstate: test that state lock is not held during icon download
olivercalder Feb 18, 2025
9a8f167
o/snapstate/backend: adjust error messages
olivercalder Feb 19, 2025
396ab2f
o/snapstate: don't download icon in old compatibility path
olivercalder Feb 19, 2025
487ebf8
o/snapstate: restore snap download context to tomb context
olivercalder Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
o/snapstate: test that state lock is not held during icon download 
Signed-off-by: Oliver Calder <oliver.calder@canonical.com>
  • Loading branch information
@olivercalder
olivercalder committed Feb 20, 2025
commit 1e4c4304af681e7eade6bd89fec48a4e92aa118b
3 changes: 3 additions & 0 deletions overlord/snapstate/backend_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -946,6 +946,9 @@ func (f *fakeStore) Download(ctx context.Context, name, targetFn string, snapInf
}

func (f *fakeStore) DownloadIcon(ctx context.Context, name string, targetPath string, downloadURL string) error {
// we don't want to hold state lock while waiting on the icon download
f.pokeStateLock()

if f.downloadIconCallback != nil {
f.downloadIconCallback(targetPath)
}
Expand Down