Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i/builtin: mock apparmor consistently for the tests #14376

Merged
merged 1 commit into from
Aug 16, 2024
Merged

i/builtin: mock apparmor consistently for the tests #14376

merged 1 commit into from
Aug 16, 2024

Conversation

pedronis
Copy link
Collaborator

also add a "allow all" test as there wasn't one afaict

@pedronis
i/builtin: mock apparmor consistently for the tests
3279db9 
also add a "allow all" test as there wasn't one afaict
@pedronis pedronis added this to the 2.65 milestone Aug 16, 2024
Meulengracht
Meulengracht approved these changes Aug 16, 2024
View reviewed changes
interfaces/builtin/lxd_support_test.go
@@ -115,6 +117,19 @@ func (s *LxdSupportInterfaceSuite) TestAppArmorSpecUserNS(c *C) {
c.Assert(spec.SnippetForTag("snap.consumer.app"), testutil.Contains, "userns,\n")
}

func (s *LxdSupportInterfaceSuite) TestAppArmorSpecAllowAll(c *C) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you

ZeyadYasser
ZeyadYasser approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@ZeyadYasser ZeyadYasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sergiocazzolato sergiocazzolato added the Skip spread Indicate that spread job should not run label Aug 16, 2024
@sergiocazzolato sergiocazzolato merged commit 552151e into canonical:master Aug 16, 2024
74 of 106 checks passed
ernestl added a commit to ernestl/snapd that referenced this pull request Aug 17, 2024
@ernestl
Revert "i/builtin: mock apparmor consistently for the tests (canonica…
31c579e 
…l#14376)"

This reverts commit 552151e.
@ernestl ernestl mentioned this pull request Aug 17, 2024
Merged
pedronis pushed a commit that referenced this pull request Aug 17, 2024
@ernestl
i/builtin: mock apparmor consistently for the tests (#14383)
78bbc48 
* Revert "i/builtin: mock apparmor consistently for the tests (#14376)"

This reverts commit 552151e.

* i/builtin: mock apparmor consistently for the tests
@pedronis pedronis deleted the lxd-support-mock-fix branch February 10, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meulengracht Meulengracht Meulengracht approved these changes

@ZeyadYasser ZeyadYasser ZeyadYasser approved these changes

@alexmurray alexmurray Awaiting requested review from alexmurray

@ernestl ernestl Awaiting requested review from ernestl

Assignees
No one assigned
Labels
Skip spread Indicate that spread job should not run Test Robustness
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pedronis @Meulengracht @ZeyadYasser @sergiocazzolato