Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spread.yaml: make lxd-state install latest/stable instead of latest/candidate #13716

Rate limit · GitHub

Whoa there!

You have triggered an abuse detection mechanism.

Please wait a few minutes before you try again;
in some cases this may take up to an hour.

Conversation

ernestl
Copy link
Collaborator

@ernestl ernestl commented Mar 15, 2024

LXD from v5.21 adds "LTS" after version number for LTS versions when calling lxd --version which breaks snapcraft due to a snapcraft bug discussed here

The error: https://paste.ubuntu.com/p/2vwwkkw5Ty/

Where the error happens: https://github.com/snapcore/snapd/blob/master/tests/nested/manual/muinstaller-core/task.yaml#L99-L104

This fix proposal is to use latest/stable instead for all our testing. This impacts:

regression/lp-1871652/task.yaml:    lxc exec bionic -- snap install lxd --channel="$LXD_SNAP_CHANNEL"
main/lxd/task.yaml:    lxd.lxc exec my-nesting-ubuntu -- snap install lxd --channel="$LXD_SNAP_CHANNEL"

regression/lp-1867193/task.yaml:    "$TESTSTOOLS"/lxd-state prepare-snap
regression/lp-1867752/task.yaml:    "$TESTSTOOLS"/lxd-state prepare-snap
regression/lp-1815869/task.yaml:    "$TESTSTOOLS"/lxd-state prepare-snap
regression/lp-1871652/task.yaml:    "$TESTSTOOLS"/lxd-state prepare-snap
nested/manual/muinstaller-core/task.yaml:  "$TESTSTOOLS"/lxd-state prepare-snap
nested/manual/devmode-snaps-can-run-other-snaps/task.yaml:  "$TESTSTOOLS"/lxd-state prepare-snap
main/lxd-snapfuse/task.yaml:    "$TESTSTOOLS"/lxd-state prepare-snap
main/lxd-no-fuse/task.yaml:    "$TESTSTOOLS"/lxd-state prepare-snap
main/selinux-lxd/task.yaml:    "$TESTSTOOLS"/lxd-state prepare-snap
main/snapd-snap/task.yaml:        "$TESTSTOOLS"/lxd-state prepare-snap
main/lxd-postrm-purge/task.yaml:    "$TESTSTOOLS"/lxd-state prepare-snap
main/lxd-try/task.yaml:  "$TESTSTOOLS"/lxd-state prepare-snap
main/lxd/task.yaml:    "$TESTSTOOLS"/lxd-state prepare-snap
main/lxd-mount-units/task.yaml:    "$TESTSTOOLS"/lxd-state prepare-snap`

@ernestl ernestl added the Run nested The PR also runs tests inluded in nested suite label Mar 15, 2024
@ernestl ernestl added this to the 2.62 milestone Mar 15, 2024
@ernestl ernestl closed this Mar 15, 2024
@ernestl ernestl reopened this Mar 15, 2024
@ernestl ernestl added the Simple 😃 A small PR which can be reviewed quickly label Mar 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.91%. Comparing base (f29db25) to head (3c022ed).
Report is 11 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #13716   +/-   ##
=======================================
  Coverage   78.90%   78.91%           
=======================================
  Files        1041     1043    +2     
  Lines      134291   134353   +62     
=======================================
+ Hits       105961   106022   +61     
- Misses      21715    21720    +5     
+ Partials     6615     6611    -4     
Flag Coverage Δ
unittests 78.91% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alfonsosanchezbeato alfonsosanchezbeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a TODO to revert when the problem is fixed?

@ernestl
Copy link
Collaborator Author

ernestl commented Mar 15, 2024

Should we add a TODO to revert when the problem is fixed?

Good idea, although I think we need to discuss the general questions of (1) using stable external tools VS (2) testing the stability of external tools/dependencies (some of this is arguable the job of the other projects themselves e.g. snapcraft)

Added: https://warthogs.atlassian.net/browse/SNAPDENG-18479 as reminder to revisit

@ernestl ernestl force-pushed the change_lxd_revision_until_starcraft_compat_fixed branch from 7a46a97 to 3c022ed Compare March 15, 2024 11:04
Copy link
Member

@alfonsosanchezbeato alfonsosanchezbeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ernestl ernestl merged commit 70b14d5 into canonical:master Mar 15, 2024
35 of 43 checks passed
sergiocazzolato added a commit to sergiocazzolato/snapd that referenced this pull request Apr 15, 2024
sergiocazzolato added a commit to sergiocazzolato/snapd that referenced this pull request Apr 29, 2024
sergiocazzolato added a commit that referenced this pull request Apr 29, 2024
* tests: use lxd snap from candidate in spread tests

This is the revert of the change
#13716

* revert changes related to snapcraft too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run nested The PR also runs tests inluded in nested suite Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rate limit · GitHub

Whoa there!

You have triggered an abuse detection mechanism.

Please wait a few minutes before you try again;
in some cases this may take up to an hour.

5 participants