-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spread.yaml: make lxd-state install latest/stable instead of latest/candidate #13716
spread.yaml: make lxd-state install latest/stable instead of latest/candidate #13716
Whoa there!
You have triggered an abuse detection mechanism.
Please wait a few minutes before you try again;
in some cases this may take up to an hour.
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #13716 +/- ##
=======================================
Coverage 78.90% 78.91%
=======================================
Files 1041 1043 +2
Lines 134291 134353 +62
=======================================
+ Hits 105961 106022 +61
- Misses 21715 21720 +5
+ Partials 6615 6611 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a TODO to revert when the problem is fixed?
Good idea, although I think we need to discuss the general questions of (1) using stable external tools VS (2) testing the stability of external tools/dependencies (some of this is arguable the job of the other projects themselves e.g. snapcraft) Added: https://warthogs.atlassian.net/browse/SNAPDENG-18479 as reminder to revisit |
7a46a97
to
3c022ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is the revert of the change canonical#13716
This is the revert of the change canonical#13716
* tests: use lxd snap from candidate in spread tests This is the revert of the change #13716 * revert changes related to snapcraft too
LXD from v5.21 adds "LTS" after version number for LTS versions when calling
lxd --version
which breaks snapcraft due to a snapcraft bug discussed hereThe error: https://paste.ubuntu.com/p/2vwwkkw5Ty/
Where the error happens: https://github.com/snapcore/snapd/blob/master/tests/nested/manual/muinstaller-core/task.yaml#L99-L104
This fix proposal is to use latest/stable instead for all our testing. This impacts: