multiple: clear up naming convention for cpu-set quota #12085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
approved these changes
Aug 29, 2022
mardy
approved these changes
Sep 2, 2022
| AllowedCPUs []int | ||
| AllowedCPUsSet bool | ||
| CPUSet []int | ||
| CPUSetSet bool |
There was a problem hiding this comment.
Ah, the wonders of the English language! :-)
There was a problem hiding this comment.
I'll admit it I didn't feel great when I looked at this haha!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of my leftovers from the cpu-quota implementation. We should use CPUSet instead of AllowedCPUs internally so it matches our quota option, only when writing it to systemd will we use AllowedCPUs