desktop/desktopentry: add a test for the "is not an absolute URI" case

canonical · Sep 6, 2023 · dfece4e · dfece4e
1 parent 9760176
commit dfece4e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/desktop/desktopentry/expand_exec.go b/desktop/desktopentry/expand_exec.go
@@ -38,7 +38,7 @@ func toFilePath(uri string) (string, error) {
 		return "", err
 	}
 	if !u.IsAbs() {
-		return "", fmt.Errorf("%q is not absolute", uri)
+		return "", fmt.Errorf("%q is not an absolute URI", uri)
 	}
 	if u.Scheme != "file" {
 		return "", fmt.Errorf("%q is not a file URI", uri)

diff --git a/desktop/desktopentry/expand_exec_test.go b/desktop/desktopentry/expand_exec_test.go
@@ -102,6 +102,14 @@ func (s *desktopentrySuite) TestExpandExecHelper(c *C) {
 	}, {
 		in:  `foo "unclosed double quote`,
 		err: "EOF found when expecting closing quote",
+	}, {
+		in:   `foo %f`,
+		uris: []string{"/foo"},
+		err:  `"/foo" is not an absolute URI`,
+	}, {
+		in:   `foo %f`,
+		uris: []string{"foo/bar"},
+		err:  `"foo/bar" is not an absolute URI`,
 	}} {
 		c.Logf("tc %d", i)