Modernize the sftp server#4871
Draft
tobe2098 wants to merge 13 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## sshfs-path-normalization #4871 +/- ##
============================================================
- Coverage 87.79% 87.78% -0.00%
============================================================
Files 269 269
Lines 14636 14625 -11
============================================================
- Hits 12848 12837 -11
Misses 1788 1788 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Normalize target path and improve link formatting as well.
When not following the symlink we should still check for intermediate symlinks not being broken
And clarify variable names in test
Add magic number replacements
Changed macro names for consistency as well
Also replace lexically_normal with our normalization in utils
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR modernizes the SFTP code:
Related Issue(s)
Closes # (issue number)
Testing
Unit tests
Manual testing steps:
Screenshots (if applicable)
Checklist
Additional Notes