fix: warn when launch timeout skips mounts#4854
Conversation
tobe2098
left a comment
There was a problem hiding this comment.
Thank you for the contribution! I would like to point out that if there are multiple mounts, some mounts may have succeeded while others have not in the start-up process, the message should reflect that. What do you think @amylily1011 ?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4854 +/- ##
==========================================
+ Coverage 87.67% 87.77% +0.11%
==========================================
Files 269 269
Lines 14603 14584 -19
==========================================
- Hits 12801 12800 -1
+ Misses 1802 1784 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b099ed0 to
1de2c20
Compare
1de2c20 to
55f41eb
Compare
|
Thanks, that makes sense. I updated the warning so it no longer says that all requested mounts were not attempted. It now says that one or more requested mounts may not have completed before launch timed out, and includes the requested mount paths so users can see which mounts are affected by the timeout uncertainty. |
Description
launch --timeoutmessage when--mountoptions are pending.--mountroutes are applied only afterrequest_launch()completes successfully. When the client-side timeout fires first, the previous message only said launch timed out and did not mention the skipped mount setup.Related Issue(s)
Closes #4831
Checklist
Additional Notes
I noticed #4663 adds broader message handling for daemon/client replies. For this issue, I kept the change in the client launch timeout path because the timeout is triggered before the later mount phase is reached.