feat: add Terraform module for mlflow-server #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI is failing because of issues with the docs, #275 should fix this issue. |
NohaIhab
reviewed
Sep 25, 2024
* feat: add Terraform module for mlflow-server This commit adds the terraform/ directory to the root of the repository to host the Terraform module of this charm. This follows the standard set in CC006. For more information please also refer to canonical/argo-operators/pull/198. Fixes #266
* ci: remove the channel from terraform checks Since the default for deploying the charm is now set to latest/edge in the re-usable workflow, this is not required anymore. Part of #266 * docs: remove compatibility note The latest standard for the terraform/ README.md is that the compatibility note can be obviated since the module at the branch is compatible with the charm in the same branch. Part of #266
DnPlas
force-pushed
the
KF-6242-terraform-module-mlflow-server-track
branch
from
a1596ce
to
4e99cb5
Compare
orfeas-k
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports the following Terraform changes from
mainintotrack/2.15:Since the default for deploying the charm is now set to latest/edge in
the re-usable workflow, this is not required anymore
The latest standard for the terraform/ README.md is that the compatibility
note can be obviated since the module at the branch is compatible with the
charm in the same branch.
This commit adds the terraform/ directory to the root of the repository to host
the Terraform module of this charm. This follows the standard set in CC006.
For more information please also refer to canonical/argo-operators/pull/198.
Part of #266