feat: add Terraform module for mlflow-server #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the terraform/ directory to the root of the repository to host the Terraform module of this charm. This follows the standard set in CC006. For more information please also refer to canonical/argo-operators/pull/198. Fixes #266
DnPlas
force-pushed
the
KF-6242-terraform-module-mlflow-server
branch
from
17eb6e7
to
6d3ae20
Compare
orfeas-k
reviewed
Sep 19, 2024
There was a problem hiding this comment.
Looks like the PR is working but we 'll need to file and issue and skip the apply job. The charm isn't going to blocked, rather it stays in waiting
Model Controller Cloud/Region Version SLA Timestamp
kubeflow microk8s microk8s/localhost 3.4.5 unsupported 12:39:00+03:00
App Version Status Scale Charm Channel Rev Address Exposed Message
mlflow-server waiting 1 mlflow-server latest/edge 696 10.152.183.70 no installing agent
Unit Workload Agent Address Ports Message
mlflow-server/0* waiting idle 10.1.217.9 Waiting for object-storage relation data
This is not the same for other relations where e.g. it goes to blocked when there's no database related
mlflow-server/0* blocked idle 10.1.217.9 Please add relation to the database
orfeas-k
reviewed
Sep 19, 2024
DnPlas
added a commit
that referenced
this pull request
Sep 24, 2024
* feat: add Terraform module for mlflow-server This commit adds the terraform/ directory to the root of the repository to host the Terraform module of this charm. This follows the standard set in CC006. For more information please also refer to canonical/argo-operators/pull/198. Fixes #266
DnPlas
added a commit
that referenced
this pull request
Sep 25, 2024
* feat: add Terraform module for mlflow-server This commit adds the terraform/ directory to the root of the repository to host the Terraform module of this charm. This follows the standard set in CC006. For more information please also refer to canonical/argo-operators/pull/198. Fixes #266
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the terraform/ directory to the root of the repository to host the Terraform module of this charm. This follows the standard set in CC006. For more information please also refer to canonical/argo-operators/pull/198.
Fixes #266
Testing instructions
tox -e tflintterraform apply -var "channel=latest/edge" -var "model_name=kubeflow" --auto-approveFor reviewers
This module must expose all the information in the
metadata.yamlof this charm, make sure you review it by comparing that file to the Tf files in this PR.