Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests are missing for volume's workload #29

Open
ca-scribner opened this issue Jun 29, 2022 · 4 comments
Open

Integration tests are missing for volume's workload #29

ca-scribner opened this issue Jun 29, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@ca-scribner
Copy link
Contributor

See #27, #28

@ca-scribner ca-scribner added the bug Something isn't working label Jun 29, 2022
@orfeas-k
Copy link
Contributor

Does this still stand? I see that there are some disabled tests in main but do we need them?

Although, not 100% relevant, we agreed in canonical/bundle-kubeflow#621 to test web apps using their unit/k8s-svc IP instead of going through Istio's ingress gateway. Thus, if we decide to keep those, we could change this too.

Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5272.

This message was autogenerated

@orfeas-k orfeas-k changed the title Fix and Re-enable broken integration tests on master and track-1.4 Integration tests are missing for volume's workload Jan 31, 2024
@orfeas-k
Copy link
Contributor

This is still relevant. There are no integration tests for the charm's workload.

@orfeas-k
Copy link
Contributor

orfeas-k commented Feb 1, 2024

Instead of creating a new task, when tackling this one we should also take into account that during canonical/bundle-kubeflow#621, it was agreed to test web apps charms by using the unit/k8s-svc IP directly instead of going through istio's ingressgateway. Thus, we should remove istio charms from integration tests. By removing istio, tests will also be independent of istio charms' failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Labeled
Development

No branches or pull requests

2 participants