Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused aggregation clusterRoles on refresh #50

Open
DnPlas opened this issue Apr 11, 2023 · 1 comment
Open

Remove unused aggregation clusterRoles on refresh #50

DnPlas opened this issue Apr 11, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@DnPlas
Copy link
Contributor

DnPlas commented Apr 11, 2023

Charms that were rewritten from podspec to sidecar pattern do not require kubeflow-roles-operator to create their aggregation clusterRoles because they are now capable of doing that for themselves using lightkube. In that case, the kubeflow-roles-operator must ensure that on upgrade event, it is removing the aggregation clusterRoles that will be duplicated.

Rationale

Two charms will attempt to create, apply, or patch the same resource, which can cause conflicts.

@NohaIhab
Copy link
Contributor

hi @DnPlas
In our upgrade guides we are instructing to remove and re-deploy kubeflow-roles charm for this reason you mentioned.
check it out here and here.
We can definitely improve our upgrade story in the future by handling this in the charm with an upgrade event handler. I'll mark this issue as an enhancement and we can pick it up in Kubeflow 1.9.

@NohaIhab NohaIhab added the enhancement New feature or request label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Labeled
Development

No branches or pull requests

2 participants