Skip to content

Latest commit

 

History

History
17 lines (13 loc) · 1.45 KB

CONTRIBUTING.md

File metadata and controls

17 lines (13 loc) · 1.45 KB

Update image gathering scripts

For every release, we'll need to update the image gather scripts for fetching the images used by Knative Charms.

To get an overview of how the script works please read #142 The script has a limitation on how it's deducing images from upstream manifests, which is tracked in #220

The script also needs to gather images for net-istio, that has it's own release cadance (although almost 1-1 with Knative Serving, but sometimes tags for Serving might not exist for net-istio).

Process:

  1. Confirm the Knative Serving version
  2. Deduce the net-istio that should be used
  • If you update based on a Kubeflow release, then you can deduce this from upstream Kubeflow manifests (make sure to checkout to correct release branch). Note that in the Kubeflow's README this will be referred as Knative ingress controller for Istio
  • If you update to an arbitrary Knative Serving version, then check the branches of net-istio and pick the closest one to your Knative Serving release
  1. Update the tools/get-images.sh script to use the selected version of net-istio
  • If the net-istio tag is not 1-1 with the Serving version then hardcode the version of net-istio in the script