Skip to content

Version selector always visible #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2019
Merged

Version selector always visible #541

merged 2 commits into from
Jun 13, 2019

Conversation

jamiemccue
Copy link
Contributor

@jamiemccue jamiemccue commented Jun 12, 2019 •
edited
Loading

Small screen
Screen Shot 2019-06-13 at 8 45 19 AM

Small screen brands
Screen Shot 2019-06-13 at 8 45 34 AM

Small screen version
Screen Shot 2019-06-13 at 8 45 47 AM

Responsive
version-selector

@jamiemccue jamiemccue requested a review from chasenlehara June 12, 2019 17:18
chasenlehara
chasenlehara requested changes Jun 13, 2019
View reviewed changes
Copy link
Member

@chasenlehara chasenlehara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn’t look like the dropdown works correctly:
version selector

chasenlehara
chasenlehara reviewed Jun 13, 2019
View reviewed changes
@chasenlehara chasenlehara merged commit 26deb1c into master Jun 13, 2019
@chasenlehara chasenlehara deleted the show-version-selector-small-screens branch June 13, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chasenlehara chasenlehara chasenlehara requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamiemccue @chasenlehara