Test failures for Tumbleweed i586

[brejoc]

Hi folks, I'd like to update joker to v1.4.0 for openSUSE, but I'm currently running into an issue with the tests for Tumbleweed i586. v1.3.5 was still building fine. The changes to tests/eval/url-test.joke don't necessarily look like they are the reason for that. Anybody else noticed something similar to what can be seen in the build log?

Guess I'll have to spin up an i586 machine somewhere. 😅

[candid82]

@brejoc The test failure seems to be caused by the fact that Joker was built for 32-bit OS. E.g.

[   39s] expected: (= (hash "hey") 4290027229N)
[   39s]   actual: (not (= -4940067 4290027229N))

4290027229 fits in uint32, but overflows (to -4940067) in int on 32-bit platforms.

32-bit was never "officially" supported, in the sense that I don't test Joker on 32-bit platforms. I do know that people successfully build Joker on 32-bit platforms and it seems to work fine. However, based on the error message above I am not sure if those hash tests ever passed on 32-bit platforms.

Could you pleas double check that v1.3.5 was indeed building fine on 32-bit platforms?

[brejoc]

@candid82 Oh, I just realized that I worked on the update before and added running the tests somewhen after the build for 1.3.5. 🤦

Means I should spin up an i586 box and do some manual testing. Factory builds don't include i586, so we are good there, and I might just disable tests for i586 in devel:languages:clojure/joker. Thanks a lot for your help!