Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(distro/wildfly): update deprecated javax module descriptor usages #4135

Merged
merged 41 commits into from
Mar 5, 2024
Merged

chore(distro/wildfly): update deprecated javax module descriptor usages #4135

merged 41 commits into from
Mar 5, 2024

Conversation

yanavasileva
Copy link
Member

@yanavasileva yanavasileva added ci:jbosseap Runs the builds for the JBoss EAP application server. ci:jdk Runs the builds for all supported Java versions. ci:wildfly Runs the builds for the Wildfly application server. labels Feb 27, 2024
@yanavasileva yanavasileva self-assigned this Feb 27, 2024
@yanavasileva yanavasileva mentioned this pull request Feb 27, 2024
Closed
@yanavasileva
java-uuid-generator: java.base
2530b5b
@yanavasileva
h2
a0b91e6 
java.compiler,
java.desktop,
java.instrument,
java.logging,
java.management,
java.naming,
java.scripting,
java.sql,
@yanavasileva
icu4j
c265d20 
java.base,
java.desktop,
java.logging
@yanavasileva
java.base,java.naming,java.security.jgss
ca44ae9 
java.base,
java.naming,
java.security.jgss
@yanavasileva
commons-codec
9c765ff 
java.base
@yanavasileva
commons-logging
4826229 
java.base
java.logging
@yanavasileva
json-path
55b259a 
java.base
@yanavasileva
httpcore
d949833 
java.base
@yanavasileva
groovy-all
f3868db 
java.base,
java.desktop,
java.management.rmi,
java.prefs,
java.scripting,
java.sql,
jdk.unsupported
@yanavasileva
camunda-engine
4989a06 
java.base,
java.desktop,
java.management,
java.naming,
java.scripting,
java.sql
@yanavasileva
mybatis
356a13c 
java.base,java.desktop,java.instrument,java.management,java.naming,java.sql,jdk.attach,jdk.jdi
@yanavasileva
joda-time
db5791b 
java.base
@yanavasileva
graal-sdk
d486858 
java.base,java.logging
@yanavasileva
freemarker
44b2328 
java.base,java.desktop,java.rmi,java.sql
@yanavasileva
template-engines-freemarker
04cc849 
java.base,java.scripting
@yanavasileva
plugin-connect -> java.base
c0750b3
@yanavasileva
plugin-spin -> java.base
e216466
@yanavasileva
engine-dmn
d9c0924 
java.base,java.desktop,java.scripting
@yanavasileva
identity-ldap
193ce0a 
java.base,java.naming
@yanavasileva
bpmn-model -> java.base,java.xml
5f65841
@yanavasileva
dmn-model -> java.base,java.xml
7f74b6f
@yanavasileva
xml-model -> java.base,java.logging,java.xml
876ecab
@yanavasileva
cmmn-model -> java.base,java.xml
29ae942
yanavasileva and others added 16 commits February 29, 2024 11:44
@yanavasileva
wildfly-subsystem -> java.base,java.sql
d896f71
@yanavasileva
commons-logging -> java.base
ccc8929
@yanavasileva
commons-utils -> java.base
9dbe948
@yanavasileva
commons-typed-values
f42400f 
java.base,java.compiler,java.desktop,java.logging
@yanavasileva
connect -> java.base
4c9348c
@yanavasileva
spin-core -> java.base
37d80a2
@yanavasileva
spin-dataformat-json-jackson -> java.base
bcf8379
@yanavasileva
spin-dataformat-xml-dom-jakarta -> java.base,java.desktop
6ba5f59
@yanavasileva
Merge branch 'master' into 3588-wildfly-remove-javax-module-descriptor
cee6cc7
@yanavasileva
org.graalvm.js.js-scriptengine -> java.base,java.scripting
bc4461a
@yanavasileva
org.graalvm.js.js -> java.base,java.management,jdk.unsupported
3e7c7b8
@yanavasileva
org.graalvm.regex.regex -> java.base,java.logging,jdk.unsupported
f37e14d
@yanavasileva
graalvm truffle-api-> java.base,java.management,java.sql,jdk.unsupported
7601cd1
@yanavasileva
jackson add java.base
89ccf42
@yanavasileva
h2database
ff92ca4 
java.base,java.compiler,java.desktop,java.instrument,java.management,java.naming,java.scripting,java.sql,jdk.net
@yanavasileva
java-uuid-generator -> org.slf4j
d28168a
@yanavasileva yanavasileva marked this pull request as ready for review February 29, 2024 16:54
danielkelemen
danielkelemen approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@danielkelemen danielkelemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

distro/wildfly/modules/src/main/modules/com/h2database/h2/main/module.xml
<dependencies>
<module name="java.base"/>
<module name="java.compiler"/>
<module name="java.desktop"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓Does it really need java.desktop?
Update: I saw that the official wildfly repo defines it as well.

Copy link
Member Author

@yanavasileva yanavasileva Mar 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, also the commit message here (ff92ca4) contains the result of the jdeps command.

@yanavasileva yanavasileva merged commit 52299e8 into master Mar 5, 2024
4 checks passed
@yanavasileva yanavasileva deleted the 3588-wildfly-remove-javax-module-descriptor branch March 5, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielkelemen danielkelemen danielkelemen approved these changes

Assignees

@yanavasileva yanavasileva

Labels
ci:jbosseap Runs the builds for the JBoss EAP application server. ci:jdk Runs the builds for all supported Java versions. ci:wildfly Runs the builds for the Wildfly application server.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanavasileva @danielkelemen