CAM-13629: enable quarkus application.properties for the process engine config #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasso94
requested changes
Aug 18, 2021
There was a problem hiding this comment.
Looks good to me in general. Can we add the following test scenarios:
- Mixed programmatic and
application.propertiesbased configuration. - Mixed process engine, job executor, and Quarkus Extension specific (
datasource) configuration.
Additionally, see comments below.
...ntime/src/main/java/org/camunda/bpm/quarkus/engine/extension/impl/CamundaEngineRecorder.java
Outdated
Show resolved
Hide resolved
...gine/runtime/src/main/java/org/camunda/bpm/quarkus/engine/extension/CamundaEngineConfig.java
Outdated
Show resolved
Hide resolved
Base automatically changed from
CAM-13811-quarkus-camunda-thread-pool
to
master
August 19, 2021 07:05
* Allow for the process engine to be configured through an applicaton.properties file using a generic properties map which is applied to the QuarkusProcessEngineConfiguration instance through reflection. Related to CAM-13629
koevskinikola
force-pushed
the
CAM-13629-quarkus-config-props
branch
from
ce3dfc0 to
ab299aa
Compare
tasso94
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to CAM-13629