Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecated javax module descriptor usages #3588

Closed
1 task done
Tracked by #3780
danielkelemen opened this issue Jul 18, 2023 · 4 comments
Closed
1 task done
Tracked by #3780

Update deprecated javax module descriptor usages #3588

danielkelemen opened this issue Jul 18, 2023 · 4 comments
Assignees
@yanavasileva
Labels
scope:core-api Changes to the core API: engine, dmn-engine, feel-engine, REST API, OpenAPI type:subtask Issues that are subtasks of another issue. Must always be part of the breakdown of the parent issue. version:7.21.0-alpha4 version:7.21.0

Comments

@danielkelemen
Copy link
Member

danielkelemen commented Jul 18, 2023 •
edited by yanavasileva
Loading

Acceptance Criteria (Required on creation)

Hints

  • javax.api. Replace is one of combination of:
    • java.se
    • java.xml
    • java.xml.crypto
    • jdk.xml.dom
    • use jdeps to ensure which one
  • the rest replace javax.* with jakarta.*
    • See for an example commit for jackson libraries: 620b877

Links

Breakdown

Pull requests
Preview Give feedback
  1. chore(distro/wildfly): update deprecated javax module descriptor usages #4135
    ci:jbosseap ci:jdk ci:wildfly
    yanavasileva
@danielkelemen danielkelemen mentioned this issue Jul 18, 2023
Closed
1 task
@danielkelemen danielkelemen added type:subtask Issues that are subtasks of another issue. Must always be part of the breakdown of the parent issue. scope:core-api Changes to the core API: engine, dmn-engine, feel-engine, REST API, OpenAPI potential:7.20.0 labels Jul 18, 2023
@mboskamp mboskamp self-assigned this Aug 7, 2023
@yanavasileva
Copy link
Member

Removing potential label as the ticket will not be tackled in 7.20

This was referenced Sep 25, 2023
Closed
Closed
@mboskamp mboskamp removed their assignment Oct 5, 2023
@yanavasileva
Copy link
Member

yanavasileva commented Feb 12, 2024 •
edited
Loading

Resources:

@yanavasileva yanavasileva self-assigned this Feb 27, 2024
@yanavasileva yanavasileva mentioned this issue Feb 27, 2024
Merged
@yanavasileva
Copy link
Member

yanavasileva commented Feb 29, 2024 •
edited
Loading

jdeps: command to launch the Java class dependency analyzer.

Example usage of jdeps:

> jdeps.exe --print-module-deps /org/camunda/bpm/camunda-engine/7.21.0-SNAPSHOT/camunda-engine-7.21.0-SNAPSHOT.jar
java.base,java.desktop,java.management,java.naming,java.scripting,java.sql
> jdeps.exe  --ignore-missing-deps --multi-release 17 --print-module-deps --module-path \org\slf4j\slf4j-api\1.7.36\slf4j-api-1.7.36.jar \com\fasterxml\uuid\java-uuid-generator\4.3.0\java-uuid-generator-4.3.0.jar
java.base,org.slf4j  <-- TODO slf4j -->

Detected a dependency to org.slf4j for java-uuid-generator module that was not part of the module.xml before. Recently the generator version changed, in previous version there was dependency to java.logging. Decided to add org.slf4j to have the module.xml complete.

Resources:

@yanavasileva
Copy link
Member

Note to myself:

jdeps commands 
 jdeps.exe --print-module-deps  /c/tmp/cam-wildfly-31/server/wildfly-31.0.0.Final/modules/org/camunda/bpm/model/camunda-bpmn-model/main/camunda-bpmn-model-7.21.0-SNAPSHOT.jar
 jdeps.exe --print-module-deps  /c/tmp/cam-wildfly-31/server/wildfly-31.0.0.Final/modules/org/camunda/bpm/model/camunda-dmn-model/main/camunda-dmn-model-7.21.0-SNAPSHOT.jar
 jdeps.exe --print-module-deps  /c/tmp/cam-wildfly-31/server/wildfly-31.0.0.Final/modules/org/camunda/bpm/model/camunda-xml-model/main/camunda-xml-model-7.21.0-SNAPSHOT.jar
 jdeps.exe --print-module-deps  /c/tmp/cam-wildfly-31/server/wildfly-31.0.0.Final/modules/org/camunda/bpm/wildfly/camunda-wildfly-subsystem/main/camunda-wildfly-subsystem-7.21.0-SNAPSHOT.jar
 jdeps.exe --print-module-deps  /c/tmp/cam-wildfly-31/server/wildfly-31.0.0.Final/modules/org/camunda/commons/camunda-commons-logging/main/module-1.13.0.jar
 jdeps.exe --print-module-deps  /c/tmp/cam-wildfly-31/server/wildfly-31.0.0.Final/modules/org/camunda/commons/camunda-commons-typed-values/main/module-1.13.0.jar
 jdeps.exe --print-module-deps  /c/tmp/cam-wildfly-31/server/wildfly-31.0.0.Final/modules/org/camunda/commons/camunda-commons-utils/main/camunda-commons-utils-1.13.0.jar
 jdeps.exe --print-module-deps  /c/tmp/cam-wildfly-31/server/wildfly-31.0.0.Final/modules/org/camunda/connect/camunda-connect-core/main/camunda-connect-core-1.6.0.jar
 jdeps.exe --print-module-deps  /c/tmp/cam-wildfly-31/server/wildfly-31.0.0.Final/modules/org/camunda/connect/camunda-connect-http-client/main/camunda-connect-http-client-1.6.0.jar
 jdeps.exe --print-module-deps  /c/tmp/cam-wildfly-31/server/wildfly-31.0.0.Final/modules/org/camunda/connect/camunda-connect-soap-http-client/main/camunda-connect-soap-http-client-1.6.0.jar
 jdeps.exe --print-module-deps  /c/tmp/cam-wildfly-31/server/wildfly-31.0.0.Final/modules/org/camunda/spin/camunda-spin-core/main/camunda-spin-core-1.22.0.jar
 jdeps.exe --print-module-deps  /c/tmp/cam-wildfly-31/server/wildfly-31.0.0.Final/modules/org/camunda/spin/camunda-spin-dataformat-json-jackson/main/camunda-spin-dataformat-json-jackson-1.22.0.jar
 jdeps.exe --print-module-deps  /c/tmp/cam-wildfly-31/server/wildfly-31.0.0.Final/modules/org/camunda/spin/camunda-spin-dataformat-xml-dom-jakarta/main/camunda-spin-dataformat-xml-dom-jakarta-1.22.0.jar
 jdeps.exe --print-module-deps  /c/tmp/cam-wildfly-31/server/wildfly-31.0.0.Final/modules/org/camunda/template-engines/camunda-template-engines-freemarker/main/camunda-template-engines-freemarker-2.2.0.jar
  
 jdeps.exe --ignore-missing-deps -q --multi-release 17 --print-module-deps --module-path "C:\tmp\cam-wildfly-31\server\wildfly-31.0.0.Final\modules\org\graalvm\truffle\truffle-api\main\truffle-api-21.1.0.jar;C:\tmp\cam-wildfly-31\server\wildfly-31.0.0.Final\modules\org\graalvm\regex\regex\main\regex-21.1.0.jar;C:\tmp\cam-wildfly-31\server\wildfly-31.0.0.Final\modules\org\graalvm\sdk\graal-sdk\main\graal-sdk-21.1.0.jar;C:\tmp\cam-wildfly-31\server\wildfly-31.0.0.Final\modules\com\ibm\icu\icu4j\main\icu4j-68.2.jar" C:\tmp\cam-wildfly-31\server\wildfly-31.0.0.Final\modules\org\graalvm\js\js\main\js-21.1.0.jar
com.ibm.icu,java.base,java.management,jdk.unsupported,org.graalvm.truffle

 C:\Tools\jdk\jdk-17.0.4.1\bin\jdeps.exe --ignore-missing-deps -q --multi-release 17 --print-module-deps --module-path "C:\tmp\cam-wildfly-31\server\wildfly-31.0.0.Final\modules\org\graalvm\truffle\truffle-api\main\truffle-api-21.1.0.jar;C:\tmp\cam-wildfly-31\server\wildfly-31.0.0.Final\modules\org\graalvm\sdk\graal-sdk\main\graal-sdk-21.1.0.jar" C:\tmp\cam-wildfly-31\server\wildfly-31.0.0.Final\modules\org\graalvm\regex\regex\main\regex-21.1.0.jar
java.base,java.logging,jdk.unsupported,org.graalvm.truffle

 C:\Tools\jdk\jdk-17.0.4.1\bin\jdeps.exe --ignore-missing-deps -q --multi-release 17 --print-module-deps --module-path "C:\tmp\cam-wildfly-31\server\wildfly-31.0.0.Final\modules\org\graalvm\sdk\graal-sdk\main\graal-sdk-21.1.0.jar" C:\tmp\cam-wildfly-31\server\wildfly-31.0.0.Final\modules\org\graalvm\truffle\truffle-api\main\truffle-api-21.1.0.jar
java.base,java.management,java.sql,jdk.unsupported,org.graalvm.sdk

C:\Tools\jdk\jdk-17.0.4.1\bin\jdeps.exe --ignore-missing-deps -q --multi-release 17 --print-module-deps C:\tmp\cam-wildfly-31\server\wildfly-31.0.0.Final\modules\org\graalvm\sdk\graal-sdk\main\graal-sdk-21.1.0.jar
java.base,java.logging

C:\Tools\jdk\jdk-17.0.4.1\bin\jdeps.exe --ignore-missing-deps -q --multi-release 17 --print-module-deps C:\tmp\cam-wildfly-31\server\wildfly-31.0.0.Final\modules\org\graalvm\sdk\graal-sdk\main\graal-sdk-21.1.0.jar
java.base,java.logging

C:\Tools\jdk\jdk-17.0.4.1\bin\jdeps.exe --ignore-missing-deps -q --multi-release 17 --print-module-deps C:\tmp\cam-wildfly-31\server\wildfly-31.0.0.Final\modules\com\fasterxml\jackson\core\jackson-annotations\2.15.2\jackson-annotations-2.15.2.jar
java.base

C:\Tools\jdk\jdk-17.0.4.1\bin\jdeps.exe --ignore-missing-deps -q --multi-release 17 --print-module-deps C:\tmp\cam-wildfly-31\server\wildfly-31.0.0.Final\modules\com\fasterxml\jackson\core\jackson-core\2.15.2\jackson-core-2.15.2.jar 
java.base

C:\Tools\jdk\jdk-17.0.4.1\bin\jdeps.exe --ignore-missing-deps -q --multi-release 17 --print-module-deps --module-path "C:\tmp\cam-wildfly-31\server\wildfly-31.0.0.Final\modules\com\fasterxml\jackson\core\jackson-annotations\2.15.2\jackson-annotations-2.15.2.jar;C:\tmp\cam-wildfly-31\server\wildfly-31.0.0.Final\modules\com\fasterxml\jackson\core\jackson-core\2.15.2\jackson-core-2.15.2.jar" C:\tmp\cam-wildfly-31\server\wildfly-31.0.0.Final\modules\com\fasterxml\jackson\core\jackson-databind\2.15.2\jackson-databind-2.15.2.jar
com.fasterxml.jackson.annotation,com.fasterxml.jackson.core,java.base

yanavasileva added a commit that referenced this issue Mar 5, 2024
@yanavasileva
chore(distro/wildfly): update deprecated javax module descriptor usag…
52299e8 
…es (#4135)

* javax.* -> jakarta.*
* javax.api:
  * jackson-annotation, jackson-base: java.base
  * jackson-databind:,java.base,java.desktop,java.logging,java.sql,java.xml
  * java-uuid-generator: java.base,org.slf4j
  * h2database: java.base,java.compiler,java.desktop,java.instrument,java.management,java.naming,java.scripting,java.sql,jdk.net
  * icu4j: java.base,java.desktop,java.logging
  * httpclient: java.base,java.naming,java.security.jgss
  * commons-codec: java.base
  * commons-logging: java.base,java.logging
  * json-path: java.base
  * httpcore: java.base
  * groovy-all: java.base,java.desktop,java.management.rmi,java.prefs,java.scripting,java.sql,jdk.unsupported
  * camunda-engine: java.base,java.desktop,java.management,java.naming,java.scripting,java.sql
  * mybatis: java.base,java.desktop,java.instrument,java.management,java.naming,java.sql,jdk.attach,jdk.jdi
  * joda-time: java.base
  * graal-sdk: java.base,java.logging
  * freemarker: java.base,java.desktop,java.rmi,java.sql
  * template-engines-freemarker: java.base,java.scripting
  * plugin-connect -> java.base
  * plugin-spin -> java.base
  * engine-dmn: java.base,java.desktop,java.scripting
  * identity-ldap: java.base,java.naming
  * bpmn-model -> java.base,java.xml
  * dmn-model -> java.base,java.xml
  * xml-model -> java.base,java.logging,java.xml
  * cmmn-model -> java.base,java.xml
  * wildfly-subsystem -> java.base,java.sql
  * commons-logging -> java.base
  * commons-utils -> java.base
  * commons-typed-values: java.base,java.compiler,java.desktop,java.logging
  * connect -> java.base
  * spin-core -> java.base
  * spin-dataformat-json-jackson -> java.base
  * spin-dataformat-xml-dom-jakarta -> java.base,java.desktop
  * org.graalvm.js.js-scriptengine -> java.base,java.scripting
  * org.graalvm.js.js -> java.base,java.management,jdk.unsupported
  * org.graalvm.regex.regex -> java.base,java.logging,jdk.unsupported
  * graalvm truffle-api-> java.base,java.management,java.sql,jdk.unsupported
  
related to #3588
@yanavasileva yanavasileva mentioned this issue May 30, 2024
Closed
1 task
@yanavasileva yanavasileva mentioned this issue Jun 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yanavasileva yanavasileva

Labels
scope:core-api Changes to the core API: engine, dmn-engine, feel-engine, REST API, OpenAPI type:subtask Issues that are subtasks of another issue. Must always be part of the breakdown of the parent issue. version:7.21.0-alpha4 version:7.21.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danielkelemen @mboskamp @yanavasileva