Skip to content

COM-677: Remove redundant d&s markup option #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

COM-677: Remove redundant d&s markup option #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions HISTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# createsend-python history

## v9.1.4 - 13 Jun, 2025
* Removed now redundant parameter ```markup_on_design_spam_test``` from method client.set_payg_billing

## v9.1.3 - 4 Feb, 2025
* Updated cacert.pem. From [#92](https://github.com/campaignmonitor/createsend-python/pull/92)
* Updates various URLs to use HTTPS
Expand Down
5 changes: 2 additions & 3 deletions lib/createsend/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,16 +108,15 @@ def set_basics(self, company, timezone, country):
response = self._put(self.uri_for('setbasics'), json.dumps(body))

def set_payg_billing(self, currency, can_purchase_credits, client_pays, markup_percentage,
markup_on_delivery=0, markup_per_recipient=0, markup_on_design_spam_test=0):
markup_on_delivery=0, markup_per_recipient=0):
"""Sets the PAYG billing settings for this client."""
body = {
"Currency": currency,
"CanPurchaseCredits": can_purchase_credits,
"ClientPays": client_pays,
"MarkupPercentage": markup_percentage,
"MarkupOnDelivery": markup_on_delivery,
"MarkupPerRecipient": markup_per_recipient,
"MarkupOnDesignSpamTest": markup_on_design_spam_test}
"MarkupPerRecipient": markup_per_recipient}
response = self._put(self.uri_for('setpaygbilling'), json.dumps(body))

def set_monthly_billing(self, currency, client_pays, markup_percentage, monthly_scheme=None):
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

setup(
name="createsend",
version='9.1.3',
version='9.1.4',
description="A library which implements the complete functionality of the Campaign Monitor API.",
author='Campaign Monitor',
author_email='support@campaignmonitor.com',
Expand Down
1 change: 0 additions & 1 deletion test/fixtures/client_details.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
"BillingDetails": {
"CanPurchaseCredits": true,
"Credits": 500,
"MarkupOnDesignSpamTest": 0.0,
"ClientPays": true,
"BaseRatePerRecipient": 1.0,
"MarkupPerRecipient": 0.0,
Expand Down