Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version 1.1.0 fails to compile #22

Closed
teamplayer3 opened this issue Aug 12, 2022 · 8 comments
Closed

New version 1.1.0 fails to compile #22

teamplayer3 opened this issue Aug 12, 2022 · 8 comments

Comments

@teamplayer3
Copy link

When I try to compile my binary with the new version of camino, it fails with error:

error[E0658]: use of unstable library feature 'try_reserve_2'
   --> /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/camino-1.1.0/src/lib.rs:430:16
    |
430 |         self.0.try_reserve(additional)
    |                ^^^^^^^^^^^
    |
    = note: see issue #91789 <https://github.com/rust-lang/rust/issues/91789> for more information
    = help: add `#![feature(try_reserve_2)]` to the crate attributes to enable
@smoelius
Copy link
Contributor

Is it possible you are using an older nightly?

I just submitted #23 for this situation.

@teamplayer3
Copy link
Author

Yes, I'm on nightly 2022-06-09.

@finnbear
Copy link

finnbear commented Aug 12, 2022

I have same issue, when compiling trunk with nightly 2022-06-15
image

@sunshowers
Copy link
Collaborator

Thanks for the report. The PR linked above should fix this issue.

In general if you're pinning a nightly via rust-toolchain, it's also good to pin versions by checking in Cargo.lock (so you can stay on camino 1.0.9). Supporting nightlies past the point at which their version becomes stable is not something I'm going to put active effort towards, though I'll welcome patches to fix issues.

@finnbear
Copy link

it's also good to pin versions by checking in Cargo.lock

Not sure how to do this when trying to compile a 3rd party binary like trunk (with cargo install trunk in my Gitlab CI runner) but I'll see if I can find a way.

Supporting nightlies past the point at which their version becomes stable is not something I'm going to put active effort towards

Understandable :)

@sunshowers
Copy link
Collaborator

sunshowers commented Aug 12, 2022

Oh for that you can use --locked , assuming that the crate was published before camino 1.1.0 was released.

cargo install trunk --locked

(I think locked should have been the default to begin with)

@finnbear
Copy link

Oh for that you can use --locked , assuming that the crate was published before camino 1.1.0 was released.

cargo install trunk --locked

(I think locked should have been the default to begin with)

Ah, thank you very much. Trunk's website suggests using that command, but I didn't know what it meant 😂

@sunshowers
Copy link
Collaborator

sunshowers commented Aug 12, 2022

This is fixed as part of camino 1.1.1, which is now out. Thanks @smoelius for the PR and everyone for reporting the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants