Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store gradient/color information in DB [ Fixes #307 ] #322

Merged
merged 3 commits into from
Apr 5, 2020

Conversation

cjchirag7
Copy link
Contributor

@cjchirag7 cjchirag7 commented Apr 5, 2020

Fixes #307
To store the colors , provenance.analysis.setting will have a new field 'colors'

  • When mode is 'binal', length of colors is 1
  • When mode is 'gradient', length of colors is >=2

The query which was earlier something like -

{"provenance.analysis.fields":[{"name":"necrosis","range":[0,1],"value":[0,1]},{"name":"tumor","range":[0,10],"value":[0,10]}],"provenance.analysis.setting":{"mode":"gradient","field":"necrosis"}}

is modified to -

{"provenance.analysis.fields":[{"name":"necrosis","range":[0,1],"value":[0,1]},{"name":"tumor","range":[0,10],"value":[0,10]}],"provenance.analysis.setting":{"mode":"gradient","field":"necrosis",colors":["#F23112","#553172","#333117" ] }}

In case, when mode is 'binal', the value of color[0] is the selected color .

@birm birm self-requested a review April 5, 2020 17:47
@cjchirag7
Copy link
Contributor Author

A Screencast of the working
store-color-update-heatmap

apps/heatmap/init.js Outdated Show resolved Hide resolved
@birm birm self-requested a review April 5, 2020 18:39
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome; thanks!

@birm birm merged commit f8e5089 into camicroscope:develop Apr 5, 2020
@cjchirag7 cjchirag7 deleted the store-color-heatmap-update branch April 6, 2020 01:12
@birm birm mentioned this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants