Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sanitize user input #301

Merged
merged 1 commit into from
Apr 3, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 23 additions & 12 deletions apps/table.html
Original file line number Diff line number Diff line change
Expand Up @@ -25,24 +25,35 @@
<script src="./loader/loader.js"></script>
<script src="./loader/chunked_upload.js"></script>
<script>
function sanitize(string) {
const map = {
'&': '&amp;',
'<': '&lt;',
'>': '&gt;',
'"': '&quot;',
"'": '&#x27;',
"/": '&#x2F;',
};
const reg = /[&<>"'/]/ig;
return string.replace(reg, (match)=>(map[match]));
}
var existingSlideNames = [];
const allowedExtensions = ['svs', 'tif', 'tiff', 'vms', 'vmu', 'ndpi', 'scn', 'mrxs', 'bif', 'svslide'];
function validateForm(callback) {
let x = document.getElementById("slidenameRow")
for (var i = 0; i < x.cells.length - 1; i++) {
var slide = document.getElementById("slidename" + i)
if (slide.value === "") {
let slide = document.getElementById("slidename0");
//Check if slide name is empty
if (slide.value === "") {
changeStatus("UPLOAD", "Please enter slide name");
return false;
}

//Checking if silde with given name already exists
if(existingSlideNames.includes(slide.value)) {
changeStatus("UPLOAD", "Slide with given name already exists");
return false;
}
}
//Checking for extinsion
//Sanitizing input
slide.value = sanitize(slide.value);
//Checking if silde with given name already exists
if(existingSlideNames.includes(slide.value)) {
changeStatus("UPLOAD", "Slide with given name already exists");
return false;
}
//Checking for extension
let filename = document.getElementById("filename0").value
var fileExtension = filename.toLowerCase().split('.').reverse()[0];
if(!allowedExtensions.includes(fileExtension)) {
Expand Down