Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magnifier not working as expected [BUG] #296

Closed
cjchirag7 opened this issue Apr 2, 2020 · 1 comment
Closed

Magnifier not working as expected [BUG] #296

cjchirag7 opened this issue Apr 2, 2020 · 1 comment

Comments

@cjchirag7
Copy link
Contributor

Describe the bug
There are 2 bugs -

  1. Magnifier gets highlighted in the toolbar menu but it doesn't work when Ctrl + M is pressed.
  2. Also, when magnifier is selected, and after that 'measurement' or 'present labels' or any other tool is selected, it also gets simultaneously selected (highlighted), but doesn't work.

To Reproduce
Steps to reproduce the behavior for bug 2 :

  1. Go to the viewer page by opening any slide
  2. Hover over magnifier icon
  3. Click on '1.0' option
  4. Click on any other tool like measurement, present labels, etc.

Expected behavior
When the other tool is selected, magnifier should be deselected automatically.

Screencast
When magnifier is selected, following measurement, the measurement tool gets highlighted but doesn't work:
Magnifier-bug

Desktop (please complete the following information):

  • OS: Ubuntu 18.04 LTS
  • Browser Chrome
  • Version 80.0.3987.132 (Official Build) (64-bit)

Additional context
This is due to improper event 'click', used for the dropdown tools. The event 'change' should be used instead, to prevent this problem.

@cjchirag7
Copy link
Contributor Author

PR #297 fixed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant