-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customizable Heatmap Colors #93
Comments
I'd like to work on this issue @birm Can you assign it to me? |
Hello, and thanks for your interest. Looking at https://github.com/camicroscope/caMicroscope/blob/0971f1368894d000464c481c713a3392e0f6ea80/core/extension/osd-heatmap-overlay.js#L803 may be useful, as it's where colors are set. also, this code was written by @nanli-emory who may have additional pointers/advice. |
@birm I would like some more information about how to setup the project and in general, how to recreate the problem at hand. Could you please maybe list down some steps on how to recreate the current setting? I've run the docker-compose up and have all the deps installed. I think I would just like help in visualising what this feature request is exactly. |
@birm Hi, can I try to address this problem as well? |
Hello; you may find it useful to add a test heatmap to a slide; see Line 110 in d0c1101
docker exec -it ca-mongo mongo then use camic ) That should show the current color scheme.
|
@zengchu2 Sure! It's entirely possible the two of you end up with solutions that work well together too! |
this document should be reasonably useful -- https://github.com/camicroscope/Distro/blob/develop/data_types.md Please let me know if it's missing details you find important. |
To see heatmap colors as mentioned, change the mode to gradient under the gear menu. |
This is a pretty useful doc to explain heatmap data model [Camic Heatmap Data Model and Rendering] |
Hi from what i was able to find that we have two modes for drawing the heatmap, binal and gradient. The requirement is to implement a feature where user can give an input and color of heatmap is changed for both binal and gradient modes? The code here tries to get colors. But the at line https://github.com/camicroscope/caMicroscope/blob/39d2d683dc73619190b3f8b57d8f69272dbfcb63/core/extension/osd-heatmap-overlay.js#L808 we have fixed set of colors.
The test seed uses the Heatmap Data Model as mentioned in above document, what is the use of Heatmap Edited Data Model described in the document? Also other than test seed how the heatmap data is generated, What is the ideal flow in production? |
Yes, the task is about letting people add different colors (either more presets or letting users choose directly, or something of that sort). |
Thanks @rahuldeepattri! |
Is your feature request related to a problem? Please describe.
The current color scheme for the heatmaps are often useful, but may not be conveyant or visible in all contexts
Describe the solution you'd like
Addition of a mechanism to let a user define a heatmap color function (takes in the value(s) for a patch, outputs a color)
Describe alternatives you've considered
Different possible options include just adding presets, use of a single color gradient, etc.
Could also include taking in multiple fields to make a color (at simplest, imagine variables a,b,c -> r,g,b)
The text was updated successfully, but these errors were encountered: