Skip to content

Commit 6ec5654

Browse files
Martin Konicekfacebook-github-bot
authored andcommitted
BREAKING: Move RecyclerViewBackedScrollView out of open source
Summary: `RecyclerViewBackedScrollView` was added a long time ago to work around the scroll-back-when-data-is-added bug, but that has now been fixed directly in the `ScrollView` (`ReactScrollView.java`) in open source and internally. Reviewed By: astreet Differential Revision: D4482105 fbshipit-source-id: 208f21f00045d5c5a83b74ad69b3db6fa63391d7
1 parent 3ee3d2b commit 6ec5654

10 files changed

Lines changed: 2 additions & 792 deletions

File tree

Libraries/Components/ScrollView/RecyclerViewBackedScrollView.android.js

Lines changed: 0 additions & 189 deletions
This file was deleted.

Libraries/Components/ScrollView/RecyclerViewBackedScrollView.ios.js

Lines changed: 0 additions & 8 deletions
This file was deleted.

Libraries/react-native/react-native.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ const ReactNative = {
5050
get Slider() { return require('Slider'); },
5151
get SnapshotViewIOS() { return require('SnapshotViewIOS'); },
5252
get Switch() { return require('Switch'); },
53-
get RecyclerViewBackedScrollView() { return require('RecyclerViewBackedScrollView'); },
5453
get RefreshControl() { return require('RefreshControl'); },
5554
get StatusBar() { return require('StatusBar'); },
5655
get SwipeableListView() { return require('SwipeableListView'); },

ReactAndroid/src/androidTest/java/com/facebook/react/tests/BUCK

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
include_defs('//ReactAndroid/DEFS')
22

33
deps = [
4+
'//java/com/facebook/fbreact/views/recyclerview:recyclerview',
45
react_native_dep('third-party/android/support/v4:lib-support-v4'),
56
react_native_dep('third-party/java/jsr-305:jsr-305'),
67
react_native_dep('third-party/java/junit:junit'),
@@ -19,7 +20,6 @@ deps = [
1920
react_native_target('java/com/facebook/react/uimanager/annotations:annotations'),
2021
react_native_target('java/com/facebook/react/views/picker:picker'),
2122
react_native_target('java/com/facebook/react/views/progressbar:progressbar'),
22-
react_native_target('java/com/facebook/react/views/recyclerview:recyclerview'),
2323
react_native_target('java/com/facebook/react/views/scroll:scroll'),
2424
react_native_target('java/com/facebook/react/views/slider:slider'),
2525
react_native_target('java/com/facebook/react/views/swiperefresh:swiperefresh'),

ReactAndroid/src/main/java/com/facebook/react/shell/BUCK

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ android_library(
44
name = 'shell',
55
srcs = glob(['**/*.java']),
66
deps = [
7+
'//java/com/facebook/fbreact/views/recyclerview:recyclerview',
78
react_native_dep('libraries/fresco/fresco-react-native:imagepipeline'),
89
react_native_dep('libraries/soloader/java/com/facebook/soloader:soloader'),
910
react_native_dep('third-party/android/support/v4:lib-support-v4'),
@@ -45,7 +46,6 @@ android_library(
4546
react_native_target('java/com/facebook/react/views/modal:modal'),
4647
react_native_target('java/com/facebook/react/views/picker:picker'),
4748
react_native_target('java/com/facebook/react/views/progressbar:progressbar'),
48-
react_native_target('java/com/facebook/react/views/recyclerview:recyclerview'),
4949
react_native_target('java/com/facebook/react/views/scroll:scroll'),
5050
react_native_target('java/com/facebook/react/views/slider:slider'),
5151
react_native_target('java/com/facebook/react/views/swiperefresh:swiperefresh'),

ReactAndroid/src/main/java/com/facebook/react/shell/MainReactPackage.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@
6767
import com.facebook.react.views.picker.ReactDialogPickerManager;
6868
import com.facebook.react.views.picker.ReactDropdownPickerManager;
6969
import com.facebook.react.views.progressbar.ReactProgressBarViewManager;
70-
import com.facebook.react.views.recyclerview.RecyclerViewBackedScrollViewManager;
7170
import com.facebook.react.views.scroll.ReactHorizontalScrollViewManager;
7271
import com.facebook.react.views.scroll.ReactScrollViewManager;
7372
import com.facebook.react.views.slider.ReactSliderManager;
@@ -275,7 +274,6 @@ public List<ViewManager> createViewManagers(ReactApplicationContext reactContext
275274
viewManagers.add(new ReactViewPagerManager());
276275
viewManagers.add(new ReactVirtualTextViewManager());
277276
viewManagers.add(new ReactWebViewManager());
278-
viewManagers.add(new RecyclerViewBackedScrollViewManager());
279277
viewManagers.add(new SwipeRefreshLayoutManager());
280278

281279
SharedPreferences preferences = PreferenceManager.getDefaultSharedPreferences(reactContext);

ReactAndroid/src/main/java/com/facebook/react/views/recyclerview/BUCK

Lines changed: 0 additions & 23 deletions
This file was deleted.

ReactAndroid/src/main/java/com/facebook/react/views/recyclerview/NotAnimatedItemAnimator.java

Lines changed: 0 additions & 71 deletions
This file was deleted.

0 commit comments

Comments
 (0)