Skip to content

Commit 4e1dfa4

Browse files
grabboufacebook-github-bot
authored andcommitted
Fix test suite when running on a feature branch
Summary: Test suite for React Native version check relies on `ReactNativeVersion.js` file that is modified on a release branch (it contains values of a real version, not zeros). That makes it impossible for the build to pass: https://circleci.com/gh/facebook/react-native/23494 This PR mocks it with zero values, just like we mock it in other suites. I am not sure if that is desired, but works for now. CC ide Closes react#16464 Differential Revision: D6100285 Pulled By: hramos fbshipit-source-id: 784f7e14f5283403f3fa518940565e1ef19dd398
1 parent f134de5 commit 4e1dfa4

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

Libraries/Core/__tests__/ReactNativeVersionCheck-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ function _defineCheckVersionTests() {
4141
});
4242

4343
it('passes when all the versions are zero', () => {
44-
jest.dontMock('ReactNativeVersion');
44+
_mockJsVersion(0, 0, 0);
4545
_mockNativeVersion(0, 0, 0);
4646

4747
const ReactNativeVersion = require('ReactNativeVersion');

0 commit comments

Comments
 (0)