Split module codegen buck rules for cpp and objcpp

Summary: Cpp and Objcpp should not be in the same rules since codegen has different purposes. I split them into into two rules and update tests for new names.

Reviewed By: TheSavior

Differential Revision: D16599257

fbshipit-source-id: 3a8be8c0e289825f9d5db831cc2eec3d2bf9728d

Author: osdnk

packages/react-native-codegen/BUCK

@@ -129,9 +129,8 @@ rn_xplat_cxx_library(
         "PUBLIC",
     ],
     deps = [
-        "fbsource//xplat/js:React",
         ":generated_components-codegen_tests",
-        ":generated_modules-codegen_tests",
+        ":generated_objcpp_modules-codegen_tests",
     ],
 )
 

packages/react-native-codegen/DEFS.bzl

@@ -194,24 +194,47 @@ def rn_codegen(
     )
 
     rn_xplat_cxx_library(
-        name = "generated_modules-{}".format(name),
+        name = "generated_cxx_modules-{}".format(name),
         tests = [":generated_tests-{}".format(name)],
-        ios_srcs = [
-            ":{}".format(generate_module_mm_name),
-        ],
         srcs = [
             ":{}".format(generate_module_cpp_name),
         ],
         headers = [
             ":{}".format(generate_module_h_name),
         ],
-        ios_headers = [
-            ":{}".format(generate_module_hobjcpp_name),
-        ],
         exported_headers = {
             "NativeModules.cpp": ":{}".format(generate_module_cpp_name),
             "NativeModules.h": ":{}".format(generate_module_h_name),
         },
+        header_namespace = "react/modules/{}".format(name),
+        compiler_flags = [
+            "-fexceptions",
+            "-frtti",
+            "-std=c++14",
+            "-Wall",
+        ],
+        fbobjc_compiler_flags = get_apple_compiler_flags(),
+        fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + get_apple_inspector_flags(),
+        platforms = (ANDROID, APPLE),
+        preprocessor_flags = [
+            "-DLOG_TAG=\"ReactNative\"",
+            "-DWITH_FBSYSTRACE=1",
+        ],
+        visibility = ["PUBLIC"],
+        exported_deps = [
+            react_native_xplat_target("turbomodule/core:core"),
+        ],
+    )
+
+    rn_xplat_cxx_library(
+        name = "generated_objcpp_modules-{}".format(name),
+        tests = [":generated_tests-{}".format(name)],
+        ios_srcs = [
+            ":{}".format(generate_module_mm_name),
+        ],
+        ios_headers = [
+            ":{}".format(generate_module_hobjcpp_name),
+        ],
         ios_exported_headers = {
             "RCTNativeModules.h": ":{}".format(generate_module_hobjcpp_name),
             "RCTNativeModules.mm": ":{}".format(generate_module_mm_name),
@@ -225,14 +248,15 @@ def rn_codegen(
         ],
         fbobjc_compiler_flags = get_apple_compiler_flags(),
         fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + get_apple_inspector_flags(),
-        platforms = (ANDROID, APPLE),
+        platforms = (APPLE),
+        apple_sdks = (IOS),
         preprocessor_flags = [
             "-DLOG_TAG=\"ReactNative\"",
             "-DWITH_FBSYSTRACE=1",
         ],
         visibility = ["PUBLIC"],
-        exported_deps = [
-            react_native_xplat_target("turbomodule/core:core"),
+        deps = [
+            "fbsource//xplat/js:React",
         ],
     )
 

packages/react-native-codegen/buck_tests/emptyFile.mm

@@ -1,9 +1,7 @@
 #import <react/components/codegen_tests/ComponentDescriptors.h>
 #import <react/components/codegen_tests/ComponentViewHelpers.h>
-#import <react/modules/codegen_tests/NativeModules.h>
 #import <react/modules/codegen_tests/RCTNativeModules.h>
 #import <react/modules/codegen_tests/RCTNativeModules.mm>
-#import <react/modules/codegen_tests/NativeModules.cpp>
 
 // TODO: Import every prop and event to asset they're generated