From 7e0f86f34bde9f9ed07d9c3c877fca2fce8977c2 Mon Sep 17 00:00:00 2001 From: Alex Hunt Date: Mon, 27 May 2024 02:53:36 -0700 Subject: [PATCH] Revert debugger launch behaviour to default profile (#44638) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/44638 Reverts the debugger launch flow to use the default `ChromeLauncher` profile. This is the approach used in the current `--experimental-debugger` experiment and by Expo. This is motivated after a review of the tradeoffs of a guest profile — which allow us to programatically quit the browser process, however takes over system URL handling. Changelog: [Internal] Reviewed By: hoxyq Differential Revision: D57619542 fbshipit-source-id: 3713e1cf8eed61e7a70ed1e4eb58f02da845155f --- packages/dev-middleware/src/utils/DefaultBrowserLauncher.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/dev-middleware/src/utils/DefaultBrowserLauncher.js b/packages/dev-middleware/src/utils/DefaultBrowserLauncher.js index 9f4153fa3081ed..705d0c4b6d64a2 100644 --- a/packages/dev-middleware/src/utils/DefaultBrowserLauncher.js +++ b/packages/dev-middleware/src/utils/DefaultBrowserLauncher.js @@ -51,6 +51,7 @@ const DefaultBrowserLauncher: BrowserLauncher = { `react-native-debugger-frontend-${browserType}`, ); const launchedChrome = await ChromeLauncher.launch({ + ignoreDefaultFlags: true, chromeFlags: [ ...ChromeLauncher.Launcher.defaultFlags().filter( /** @@ -64,10 +65,8 @@ const DefaultBrowserLauncher: BrowserLauncher = { `--app=${url}`, `--user-data-dir=${userDataDir}`, '--window-size=1200,600', - '--guest', ], chromePath, - ignoreDefaultFlags: true, }); return {