fix: RCTReactViewController properly check props to update

callstack · Feb 26, 2024 · 2a1d10d · 2a1d10d
1 parent 45fcce8
commit 2a1d10d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/packages/react-native/Libraries/SwiftExtensions/RCTReactViewController.m b/packages/react-native/Libraries/SwiftExtensions/RCTReactViewController.m
@@ -61,9 +61,12 @@ - (void)tapGesture:(UITapGestureRecognizer*)recognizer {
 
 - (void)updateProps:(NSDictionary *)newProps {
   RCTRootView *rootView = (RCTRootView *)self.view;
-  if (![rootView.appProperties isEqualToDictionary:newProps]) {
+  if (rootView.appProperties == newProps) {
+    return;
+  }
+
+  if (newProps != nil && ![rootView.appProperties isEqualToDictionary:newProps]) {
     [rootView setAppProperties:newProps];
   }
 }
-
 @end
diff --git a/packages/react-native/Libraries/WindowManager/WindowManager.d.ts b/packages/react-native/Libraries/WindowManager/WindowManager.d.ts
@@ -1,6 +1,6 @@
 export interface WindowStatic {
   id: String;
-  open (props: Object): Promise<void>;
+  open (props?: Object): Promise<void>;
   update (props: Object): Promise<void>;
   close (): Promise<void>;
 }