fix: Allow to change background for FAB Group #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gawrysiak, thank you for your pull request 🤗. The documentation from this branch can be viewed here. Please remember to update Typescript types if you changed API. |
satya164
requested changes
Jan 27, 2019
There was a problem hiding this comment.
I think passing the background color to fab while passing rest of the styles to the container will be confusing (it's also a breaking change). There are few options:
- Pass whole
styleto FAB instead: this will be a breaking change - Add a
fabStyleprop - Don't add a prop (users can still use
theme.colors.accentto customize the FAB color)
I don't like adding props, but I'm leaning towards 2 because it's not a breaking change and is consistent with how you can customize the action buttons.
|
Updated the PR to add an extra prop. |
|
Can you also update the typescript declaration files too? |
|
Ah, sorry, missed that. It's now added. |
satya164
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It's currently possible to change the background color for FAB and also items within FAB.Group components. Changing the background color in FAB Group causes the overlay background to change.
This PR makes it possible to change the background for the FAB Group main button.
Current behavior:
Test plan
https://snack.expo.io/ryjNEaO7E