refactor: use touchable's disabled prop #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gawrysiak, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
satya164
pushed a commit
that referenced
this pull request
May 16, 2018
satya164
pushed a commit
that referenced
this pull request
May 24, 2018
satya164
pushed a commit
that referenced
this pull request
May 25, 2018
satya164
pushed a commit
that referenced
this pull request
May 25, 2018
satya164
pushed a commit
that referenced
this pull request
May 25, 2018
satya164
pushed a commit
that referenced
this pull request
May 26, 2018
eriveltonelias
pushed a commit
to eriveltonelias/react-native-paper
that referenced
this pull request
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed there's a "disabled" prop for TouchableRipple. It should be able to simplify some code areas, like the multiple conditions inside the Button component. Is this okay to use?
Test plan
Snapshot tests working fine.